From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750990AbdE1IPh (ORCPT ); Sun, 28 May 2017 04:15:37 -0400 Received: from mga14.intel.com ([192.55.52.115]:42559 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbdE1IPg (ORCPT ); Sun, 28 May 2017 04:15:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,408,1491289200"; d="scan'208";a="92725818" Date: Sun, 28 May 2017 11:13:15 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Greg Kroah-Hartman , Andreas Noever , Michael Jamet , Yehezkel Bernat , Lukas Wunner , Amir Levy , Andy Lutomirski , Mario Limonciello , Jared.Dominguez@dell.com, Andy Shevchenko , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free() Message-ID: <20170528081315.GF2784@lahna.fi.intel.com> References: <20170526160936.54265-1-mika.westerberg@linux.intel.com> <20170526160936.54265-8-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 27, 2017 at 06:41:28PM +0300, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg > wrote: > > Following the usual pattern used in many places, we allow passing NULL > > pointer to tb_ctl_free(). Then the user can call the function regardless > > if it has allocated control channel or not making the code bit simpler. > > > > +Suggested-by as you mentioned in cover letter? OK, I'll add it. BTW, should I do it for the other patch that was suggested by Andreas as well?