From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751023AbdE1JRp (ORCPT <rfc822;w@1wt.eu>);
        Sun, 28 May 2017 05:17:45 -0400
Received: from mga03.intel.com ([134.134.136.65]:23278 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750970AbdE1JRo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 28 May 2017 05:17:44 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,408,1491289200"; 
   d="scan'208";a="973939759"
Date: Sun, 28 May 2017 12:13:17 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Lukas Wunner <lukas@wunner.de>, Amir Levy <amir.jer.levy@intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Mario Limonciello <Mario.Limonciello@dell.com>,
        Jared.Dominguez@dell.com,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 24/27] thunderbolt: Add support for Internal
 Connection Manager (ICM)
Message-ID: <20170528091317.GK2784@lahna.fi.intel.com>
References: <20170526160936.54265-1-mika.westerberg@linux.intel.com>
 <20170526160936.54265-25-mika.westerberg@linux.intel.com>
 <CAHp75Vc8pDPGrJH=UixW-r+kyT5K7wQXs8aN=SzooZpH9qnUcA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vc8pDPGrJH=UixW-r+kyT5K7wQXs8aN=SzooZpH9qnUcA@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 27, 2017 at 11:45:21PM +0300, Andy Shevchenko wrote:
> On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> 
> > +static inline u8 dual_link_from_link(u8 link)
> > +{
> > +       return link ? ((link - 1) ^ 0x01) + 1 : 0;
> > +}
> 
> I have got better one (IIUC):
> 
>       return (link + 1) ^ 0x01) - 1;

Unfortunately this does not work if link is 0.