From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750983AbdE2Anv (ORCPT ); Sun, 28 May 2017 20:43:51 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:45307 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbdE2Ant (ORCPT ); Sun, 28 May 2017 20:43:49 -0400 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: hyc.lee@gmail.com X-Original-SENDERIP: 10.177.225.40 X-Original-MAILFROM: hyc.lee@gmail.com Date: Mon, 29 May 2017 09:43:46 +0900 From: Hyunchul Lee To: Christoph Hellwig Cc: Artem Bityutskiy , Richard Weinberger , adrian.hunter@intel.com, linux-kernel@vger.kernel.org, kernel-team@lge.com, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] ubifs: Add freeze support Message-ID: <20170529004346.GA10215@sebu> References: <1495755004-17036-1-git-send-email-hyc.lee@gmail.com> <20170527082338.GC32125@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170527082338.GC32125@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote: > > +static int ubifs_freeze_super(struct super_block *sb) > > +{ > > + struct ubifs_info *c = sb->s_fs_info; > > + int err; > > + > > + dbg_gen("starting"); > > + /* freeze_super always succeeds if file system is in read-only. > > + * however if there are errors, UBIFS is switched to read-only mode. > > + * so @ro_error should be checked. > > + */ > > + err = freeze_super(sb); > > + if (!err && c->ro_error) { > > + thaw_super(sb); > > + return -EIO; > > + } > > + return err; > > This is just broken. First ubifs should still properly propagate > the errors, and second freezing/unfreezing read only file systems is > perfectly valid, it is right. > and third the freeze_super method is a special > hack for gfs2 that should not gain additional users. I thought that it was ok. because commit 48b6bca says "every filesystem that implements this hooks must call the vfs freeze_super ..." Thank you for comment. > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Thanks, Hyunchul