From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750904AbdE2BSj (ORCPT ); Sun, 28 May 2017 21:18:39 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:48688 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbdE2BSh (ORCPT ); Sun, 28 May 2017 21:18:37 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: hyc.lee@gmail.com X-Original-SENDERIP: 10.177.225.40 X-Original-MAILFROM: hyc.lee@gmail.com Date: Mon, 29 May 2017 10:18:34 +0900 From: Hyunchul Lee To: Richard Weinberger Cc: Artem Bityutskiy , linux-kernel@vger.kernel.org, adrian.hunter@intel.com, kernel-team@lge.com, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] ubifs: Add freeze support Message-ID: <20170529011834.GB10215@sebu> References: <1495755004-17036-1-git-send-email-hyc.lee@gmail.com> <2f3210d7-b0c3-f006-754e-ec4bae26454c@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f3210d7-b0c3-f006-754e-ec4bae26454c@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Richard. On Fri, May 26, 2017 at 11:52:42AM +0200, Richard Weinberger wrote: > Hyunchul, > > Am 26.05.2017 um 01:30 schrieb Hyunchul Lee: > > From: Hyunchul Lee > > > > for un/freeze support, implement freeze_super and un/freeze_fs > > of super_operations. > > ubifs_freeze_super just calls freeze_super. because freeze_super always > > succeeds if file system is read-only, UBIFS errors should be checked. > > if there are errors, UBIFS is switched to read-only mode. > > ubifs_freeze_fs runs commit if TNC/LPT isn't clean. though all writes > > are blocked and sync_fs is called before, if commit alreay was started > > before writes are blocked, TNC/LPT might have dirty COW nodes. > > you explain how you implement that feature, but not why. > What is the use-case? > I always thought this interface is only being used by LVM. Sorry, I forgot this. I implement this to make a backup of some files, and support fsfreeze utility and SysRq's freeze/thaw commmand. > > Thanks, > //richard > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Thanks, Hyunchul