From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes Date: Mon, 29 May 2017 11:36:32 -0400 Message-ID: <20170529153632.GV6203@madcap2.tricolour.ca> References: <1491302268-797-1-git-send-email-rgb@redhat.com> <124499206.jtSla3cULl@x2> <20170508135200.GY25861@madcap2.tricolour.ca> <1894724.IJY7jiRZBU@x2> <20170524214658.GM6203@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170524214658.GM6203@madcap2.tricolour.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Steve Grubb Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On 2017-05-24 17:46, Richard Guy Briggs wrote: > On 2017-05-24 16:02, Steve Grubb wrote: > > On Monday, May 8, 2017 9:52:00 AM EDT Richard Guy Briggs wrote: > > > > > Ok, so coming back to patch acceptance, if I read correctly your > > > > > comments, reduce the four new error types to two? > > > > > > > > Yes, two are needed. One for missing filter/action and one for we are > > > > attempting an incompatible comparison between fields. > > > > > > Ok, here you go: > > > https://github.com/linux-audit/audit-userspace/pull/21 > > > > Was just going to look over this patch and now I see its not on the mail list. > > This version looks fine. I kind of prefer patches sent to the mail list so > > that any discussion is archived. > > No problem. I'll continue sending patches to the list. Now that the > repo is on github, it is so much more convenient to just push the > changes on one of my branches and make a pull request. I expect it is > equally easy to accept a pull request and merge straight on github. Ok, I hadn't understood that you hadn't applied it despite reviewing it and finding it fine. I'll send it to the list now. > > -Steve > > - RGB - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635