From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751146AbdE2VPJ (ORCPT ); Mon, 29 May 2017 17:15:09 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33115 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdE2VPI (ORCPT ); Mon, 29 May 2017 17:15:08 -0400 Date: Mon, 29 May 2017 14:15:05 -0700 From: "Paul E. McKenney" To: Stephen Rothwell Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Joe Perches , Mike Frysinger , Steven Miao Subject: Re: linux-next: build failure after merge of the rcu tree Reply-To: paulmck@linux.vnet.ibm.com References: <20170529160209.5230c05b@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170529160209.5230c05b@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17052921-0036-0000-0000-000002168BCA X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007141; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00867405; UDB=6.00430962; IPR=6.00647285; BA=6.00005383; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015635; XFM=3.00000015; UTC=2017-05-29 21:15:05 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17052921-0037-0000-0000-00004084DED4 Message-Id: <20170529211505.GP3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-29_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705290404 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 29, 2017 at 04:02:09PM +1000, Stephen Rothwell wrote: > Hi Paul, > > After merging the rcu tree, today's linux-next build (bfin > BF526-EZBRD_defconfig and several other bfin configs) failed like this: > > In file included from include/linux/srcu.h:60:0, > from include/linux/notifier.h:15, > from include/linux/memory_hotplug.h:6, > from include/linux/mmzone.h:777, > from include/linux/gfp.h:5, > from include/linux/kmod.h:22, > from include/linux/module.h:13, > from include/linux/moduleloader.h:5, > from arch/blackfin/kernel/module.c:9: > include/linux/srcutiny.h: In function 'srcu_torture_stats_print': > include/linux/srcutiny.h:96:2: error: 'mod' undeclared (first use in this function) > > Caused by commit > > 54ffb22bd841 ("rcutorture: Move SRCU status printing to SRCU implementations") And of course this is nothing but a printk(). > arch/blackfin/kernel/module.c includes this: > > #define pr_fmt(fmt) "module %s: " fmt, mod->name Hmmm... There are well over 1000 definitions of pr_fmt() in the kernel. Very popular name there! > added by commit > > b75a9e6bfba5 ("Blackfin: use more standard pr_fmt in the module loader") > > before v2.6.39-rc2 ... I guess I cannot claim to be blindsided by a recent change, at least not unless you take my age into account. ;-) So maybe there is some header file that blackfin wants included? There are only about 100 definitions of "mod", so let's see... Well, none of them are in blackfin, but perhaps the two in module.h? But these are just fields in structs. As is the one in moduleparam.h. At this point, the only option I see is to convert srcu_torture_stats_print() from a static inline function to a macro. Anyone see any other options? Thanx, Paul