From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 29 May 2017 15:31:24 -0600 Subject: [U-Boot] [PATCH v2 03/10] patman: Don't convert input data to unicode In-Reply-To: <20170529213132.21217-1-sjg@chromium.org> References: <20170529213132.21217-1-sjg@chromium.org> Message-ID: <20170529213132.21217-4-sjg@chromium.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The communication filter reads data in blocks and converts each block to unicode (if necessary) one at a time. In the unlikely event that a unicode character in the input spans a block this will not work. We get an error like: UnicodeDecodeError: 'utf8' codec can't decode bytes in position 1022-1023: unexpected end of data There is no need to change the input to unicode, so the easiest fix is to drop this feature. Signed-off-by: Simon Glass --- Changes in v2: None tools/patman/cros_subprocess.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/patman/cros_subprocess.py b/tools/patman/cros_subprocess.py index 7c76014340..ebd4300dfd 100644 --- a/tools/patman/cros_subprocess.py +++ b/tools/patman/cros_subprocess.py @@ -190,8 +190,6 @@ class Popen(subprocess.Popen): # We will get an error on read if the pty is closed try: data = os.read(self.stdout.fileno(), 1024) - if isinstance(data, bytes): - data = data.decode('utf-8') except OSError: pass if data == "": @@ -207,8 +205,6 @@ class Popen(subprocess.Popen): # We will get an error on read if the pty is closed try: data = os.read(self.stderr.fileno(), 1024) - if isinstance(data, bytes): - data = data.decode('utf-8') except OSError: pass if data == "": -- 2.13.0.219.gdb65acc882-goog