From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751609AbdE3J2d (ORCPT ); Tue, 30 May 2017 05:28:33 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36428 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbdE3J23 (ORCPT ); Tue, 30 May 2017 05:28:29 -0400 Date: Tue, 30 May 2017 10:28:25 +0100 From: Lee Jones To: Hans de Goede Cc: Chen-Yu Tsai , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] mfd: axp20x-i2c: Document that this must be builtin on x86 Message-ID: <20170530092825.4kootwqstks6yyei@dell> References: <20170526111531.30160-1-hdegoede@redhat.com> <20170526111531.30160-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170526111531.30160-2-hdegoede@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 May 2017, Hans de Goede wrote: > On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be AXP288 > available before other drivers using it are loaded, which can only be > ensured if the mfd, OpRegionr and i2c-bus drivers are built in. MFD OpRegion built-in > Since the axp20x mfd code is used on non X86 too we cannot simply change AXP20x MFD Either X86 or x86 -- please be consistent. > this into a bool, I've tried some Kconfig magic with if x86 but I could > not get this working correctly, so this commit just documents that this > should be builtin on x86, which fixes errors like these during boot: Once the typos have been fixed, you can apply my: For my own reference: Acked-for-MFD-by: Lee Jones > mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA > ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] > ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-2 > ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93 > ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b > acpi 80860F14:02: Failed to change power state to D0 > > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Fix Kconfig depends and selects to fix warning reported by kbuild test robot > -Improve commit msg (add example of ACPI errors this avoids) > Changes in v3: > -Since the axp20x mfd code is used on ARM too where it does not necessarily > need to be builtin settle for simply documenting the need to have this > builtin on x86 > Changes in v5: > -Fix I2C spelling > --- > drivers/mfd/Kconfig | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 4f71cab2e6e8..e03853affcc5 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -160,6 +160,11 @@ config MFD_AXP20X_I2C > components like regulators or the PEK (Power Enable Key) under the > corresponding menus. > > + Note on x86 this provides an ACPI OpRegion, so this must be 'y' > + (builtin) and not a module, as the OpRegion must be available as > + soon as possible. For the same reason the I2C bus driver options > + I2C_DESIGNWARE_PLATFORM and I2C_DESIGNWARE_BAYTRAIL must be 'y' too. > + > config MFD_AXP20X_RSB > tristate "X-Powers AXP series PMICs with RSB" > select MFD_AXP20X -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog