All of
 help / color / mirror / Atom feed
From: Dmitry Torokhov <>
To: Linus Walleij <>
Subject: Re: [PATCH 2/2 v3] input: keyboard: Add D-Link DIR-685 touchkeys driver
Date: Tue, 30 May 2017 09:40:21 -0700	[thread overview]
Message-ID: <20170530164021.GB12922@dtor-ws> (raw)
In-Reply-To: <>

Hi Linus,

On Tue, May 30, 2017 at 02:09:18PM +0200, Linus Walleij wrote:
> +	/*
> +	 * This key appears in the vendor driver, but I have
> +	 * not been able to provoke it.
> +	 */
> +	tk->codes[6] = KEY_O;

If there is no way to make the device produce this key, should we mark
is as KEY_RESERVED? KEY_O would not be suitable in any case, we'd need
to find more suitable keycode for whatever function is has.

If it is OK I can make the change locally.



  reply	other threads:[~2017-05-30 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 12:09 [PATCH 1/2 v3] input: keyboard: DT bindings for the D-Link DIR-685 touchkeys Linus Walleij
2017-05-30 12:09 ` [PATCH 2/2 v3] input: keyboard: Add D-Link DIR-685 touchkeys driver Linus Walleij
2017-05-30 16:40   ` Dmitry Torokhov [this message]
2017-05-30 23:50     ` Linus Walleij
2017-06-05 22:12   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530164021.GB12922@dtor-ws \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.