From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751088AbdE3S5U (ORCPT ); Tue, 30 May 2017 14:57:20 -0400 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:3743 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdE3S5R (ORCPT ); Tue, 30 May 2017 14:57:17 -0400 X-IronPort-AV: E=Sophos;i="5.38,419,1491264000"; d="scan'208";a="672434274" Date: Tue, 30 May 2017 11:57:07 -0700 From: Eduardo Valentin To: Johan Hovold CC: Greg Kroah-Hartman , Linus Walleij , Peter Chen , "Rob Herring" , Arnd Bergmann , Sricharan R , Zhang Rui , Eduardo Valentin , , , , Laxman Dewangan Subject: Re: [PATCH 7/7] thermal: max77620: fix pinmux conflict on reprobe Message-ID: <20170530185707.GF7419@u40b0340c692b58f6553c.ant.amazon.com> References: <20170530162554.26159-1-johan@kernel.org> <20170530162554.26159-8-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170530162554.26159-8-johan@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 06:25:54PM +0200, Johan Hovold wrote: > Use the new helper for reusing a device-tree node of another device > instead of managing the node references explicitly. > > This also makes sure that the new of_node_reuse flag is set if the > device is ever reprobed, something which specifically now avoids driver > core from attempting to claim any pinmux resources already claimed by > the parent device. > > Fixes: ec4664b3fd6d ("thermal: max77620: Add thermal driver for reporting junction temp") > Cc: Laxman Dewangan > Signed-off-by: Johan Hovold > --- > drivers/thermal/max77620_thermal.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c > index 71d35f3c9215..159bbcee8821 100644 > --- a/drivers/thermal/max77620_thermal.c > +++ b/drivers/thermal/max77620_thermal.c > @@ -112,12 +112,10 @@ static int max77620_thermal_probe(struct platform_device *pdev) > } > > /* > - * Drop any current reference to a device-tree node and get a > - * reference to the parent's node which will be balanced on reprobe or > - * on platform-device release. > + * The reference taken to the parent's node which will be balanced on > + * reprobe or on platform-device release. > */ > - of_node_put(pdev->dev.of_node); > - pdev->dev.of_node = of_node_get(pdev->dev.parent->of_node); > + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); Should this one be squashed with patch 6/7? > > mtherm->tz_device = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, > mtherm, &max77620_thermal_ops); > -- > 2.13.0 > > -- All the best, Eduardo Valentin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH 7/7] thermal: max77620: fix pinmux conflict on reprobe Date: Tue, 30 May 2017 11:57:07 -0700 Message-ID: <20170530185707.GF7419@u40b0340c692b58f6553c.ant.amazon.com> References: <20170530162554.26159-1-johan@kernel.org> <20170530162554.26159-8-johan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:3743 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdE3S5R (ORCPT ); Tue, 30 May 2017 14:57:17 -0400 Content-Disposition: inline In-Reply-To: <20170530162554.26159-8-johan@kernel.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Johan Hovold Cc: Greg Kroah-Hartman , Linus Walleij , Peter Chen , Rob Herring , Arnd Bergmann , Sricharan R , Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Laxman Dewangan On Tue, May 30, 2017 at 06:25:54PM +0200, Johan Hovold wrote: > Use the new helper for reusing a device-tree node of another device > instead of managing the node references explicitly. > > This also makes sure that the new of_node_reuse flag is set if the > device is ever reprobed, something which specifically now avoids driver > core from attempting to claim any pinmux resources already claimed by > the parent device. > > Fixes: ec4664b3fd6d ("thermal: max77620: Add thermal driver for reporting junction temp") > Cc: Laxman Dewangan > Signed-off-by: Johan Hovold > --- > drivers/thermal/max77620_thermal.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c > index 71d35f3c9215..159bbcee8821 100644 > --- a/drivers/thermal/max77620_thermal.c > +++ b/drivers/thermal/max77620_thermal.c > @@ -112,12 +112,10 @@ static int max77620_thermal_probe(struct platform_device *pdev) > } > > /* > - * Drop any current reference to a device-tree node and get a > - * reference to the parent's node which will be balanced on reprobe or > - * on platform-device release. > + * The reference taken to the parent's node which will be balanced on > + * reprobe or on platform-device release. > */ > - of_node_put(pdev->dev.of_node); > - pdev->dev.of_node = of_node_get(pdev->dev.parent->of_node); > + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); Should this one be squashed with patch 6/7? > > mtherm->tz_device = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, > mtherm, &max77620_thermal_ops); > -- > 2.13.0 > > -- All the best, Eduardo Valentin