All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: mhocko@kernel.org, guro@fb.com
Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, kernel-team@fb.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm,oom: add tracepoints for oom reaper-related events
Date: Tue, 30 May 2017 22:17:11 +0900	[thread overview]
Message-ID: <201705302217.JAI21823.FOFJtOQVOHLMSF@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20170530123415.GF7969@dhcp22.suse.cz>

Michal Hocko wrote:
> On Tue 30-05-17 13:05:32, Roman Gushchin wrote:
> > Add tracepoints to simplify the debugging of the oom reaper code.
> > 
> > Trace the following events:
> > 1) a process is marked as an oom victim,
> > 2) a process is added to the oom reaper list,
> > 3) the oom reaper starts reaping process's mm,
> > 4) the oom reaper finished reaping,
> > 5) the oom reaper skips reaping.
> 
> I am not against but could you explain why the current printks are not
> sufficient? We do not have any explicit printk for the 2) and 3) but
> are those really necessary?
> 
> In other words could you describe the situation when you found these
> tracepoints more useful than what the kernel log offers already?

Guessing from "to simplify the debugging of the oom reaper code",
Roman is facing some unknown bugs or problems?

WARNING: multiple messages have this Message-ID (diff)
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: mhocko@kernel.org, guro@fb.com
Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, kernel-team@fb.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm,oom: add tracepoints for oom reaper-related events
Date: Tue, 30 May 2017 22:17:11 +0900	[thread overview]
Message-ID: <201705302217.JAI21823.FOFJtOQVOHLMSF@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20170530123415.GF7969@dhcp22.suse.cz>

Michal Hocko wrote:
> On Tue 30-05-17 13:05:32, Roman Gushchin wrote:
> > Add tracepoints to simplify the debugging of the oom reaper code.
> > 
> > Trace the following events:
> > 1) a process is marked as an oom victim,
> > 2) a process is added to the oom reaper list,
> > 3) the oom reaper starts reaping process's mm,
> > 4) the oom reaper finished reaping,
> > 5) the oom reaper skips reaping.
> 
> I am not against but could you explain why the current printks are not
> sufficient? We do not have any explicit printk for the 2) and 3) but
> are those really necessary?
> 
> In other words could you describe the situation when you found these
> tracepoints more useful than what the kernel log offers already?

Guessing from "to simplify the debugging of the oom reaper code",
Roman is facing some unknown bugs or problems?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-05-30 13:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 12:05 [PATCH] mm,oom: add tracepoints for oom reaper-related events Roman Gushchin
2017-05-30 12:05 ` Roman Gushchin
2017-05-30 12:34 ` Michal Hocko
2017-05-30 12:34   ` Michal Hocko
2017-05-30 13:17   ` Tetsuo Handa [this message]
2017-05-30 13:17     ` Tetsuo Handa
2017-05-30 13:33   ` Roman Gushchin
2017-05-30 13:33     ` Roman Gushchin
2017-05-30 13:45     ` Michal Hocko
2017-05-30 13:45       ` Michal Hocko
2017-05-30 18:52       ` [PATCH v2] " Roman Gushchin
2017-05-30 18:52         ` Roman Gushchin
2017-05-31 16:39         ` Michal Hocko
2017-05-31 16:39           ` Michal Hocko
2017-06-01 18:41           ` Roman Gushchin
2017-06-01 18:41             ` Roman Gushchin
2017-06-02  8:13             ` Michal Hocko
2017-06-02  8:13               ` Michal Hocko
2017-06-20 13:43               ` Roman Gushchin
2017-06-20 13:43                 ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201705302217.JAI21823.FOFJtOQVOHLMSF@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.