From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152AbdEaQFt (ORCPT ); Wed, 31 May 2017 12:05:49 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17752 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbdEaQFr (ORCPT ); Wed, 31 May 2017 12:05:47 -0400 Date: Wed, 31 May 2017 09:03:53 -0700 From: "Darrick J. Wong" To: Tahsin Erdogan Cc: Jan Kara , "Theodore Ts'o" , Andreas Dilger , Dave Kleikamp , Alexander Viro , Mark Fasheh , Joel Becker , Jens Axboe , Deepa Dinamani , Mike Christie , Fabian Frederick , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 09/28] ext4: extended attribute value size limit is enforced by vfs Message-ID: <20170531160353.GH4510@birch.djwong.org> References: <20170531081517.11438-1-tahsin@google.com> <20170531081517.11438-9-tahsin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531081517.11438-9-tahsin@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2017 at 01:14:58AM -0700, Tahsin Erdogan wrote: > EXT4_XATTR_MAX_LARGE_EA_SIZE definition in ext4 is currently unused. > Besides, vfs enforces its own 64k limit which makes the 1MB limit in > ext4 redundant. Remove it. > > Signed-off-by: Tahsin Erdogan > --- > fs/ext4/ext4.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index 5d5fc0d0e2bc..2cdd6070e348 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -2221,12 +2221,6 @@ struct mmpd_data { > #define EXT4_MMP_MAX_CHECK_INTERVAL 300UL > > /* > - * Maximum size of xattr attributes for FEATURE_INCOMPAT_EA_INODE 1Mb > - * This limit is arbitrary, but is reasonable for the xattr API. > - */ > -#define EXT4_XATTR_MAX_LARGE_EA_SIZE (1024 * 1024) Uhhh... didn't you add this in patch 1/28? There's little point in adding a symbol just to delete it shortly thereafter. --D > - > -/* > * Function prototypes > */ > > -- > 2.13.0.219.gdb65acc882-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Darrick J. Wong" Subject: Re: [PATCH 09/28] ext4: extended attribute value size limit is enforced by vfs Date: Wed, 31 May 2017 09:03:53 -0700 Message-ID: <20170531160353.GH4510@birch.djwong.org> References: <20170531081517.11438-1-tahsin@google.com> <20170531081517.11438-9-tahsin@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Deepa Dinamani , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, "Theodore Ts'o" , linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, Jens Axboe , linux-fsdevel@vger.kernel.org, Mike Christie , Andreas Dilger , Alexander Viro , Jan Kara , Fabian Frederick , linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com To: Tahsin Erdogan Return-path: Content-Disposition: inline In-Reply-To: <20170531081517.11438-9-tahsin@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com List-Id: linux-ext4.vger.kernel.org On Wed, May 31, 2017 at 01:14:58AM -0700, Tahsin Erdogan wrote: > EXT4_XATTR_MAX_LARGE_EA_SIZE definition in ext4 is currently unused. > Besides, vfs enforces its own 64k limit which makes the 1MB limit in > ext4 redundant. Remove it. > > Signed-off-by: Tahsin Erdogan > --- > fs/ext4/ext4.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index 5d5fc0d0e2bc..2cdd6070e348 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -2221,12 +2221,6 @@ struct mmpd_data { > #define EXT4_MMP_MAX_CHECK_INTERVAL 300UL > > /* > - * Maximum size of xattr attributes for FEATURE_INCOMPAT_EA_INODE 1Mb > - * This limit is arbitrary, but is reasonable for the xattr API. > - */ > -#define EXT4_XATTR_MAX_LARGE_EA_SIZE (1024 * 1024) Uhhh... didn't you add this in patch 1/28? There's little point in adding a symbol just to delete it shortly thereafter. --D > - > -/* > * Function prototypes > */ > > -- > 2.13.0.219.gdb65acc882-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darrick J. Wong Date: Wed, 31 May 2017 09:03:53 -0700 Subject: [Ocfs2-devel] [PATCH 09/28] ext4: extended attribute value size limit is enforced by vfs In-Reply-To: <20170531081517.11438-9-tahsin@google.com> References: <20170531081517.11438-1-tahsin@google.com> <20170531081517.11438-9-tahsin@google.com> Message-ID: <20170531160353.GH4510@birch.djwong.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tahsin Erdogan Cc: Deepa Dinamani , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Theodore Ts'o , linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, Jens Axboe , linux-fsdevel@vger.kernel.org, Mike Christie , Andreas Dilger , Alexander Viro , Jan Kara , Fabian Frederick , linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com On Wed, May 31, 2017 at 01:14:58AM -0700, Tahsin Erdogan wrote: > EXT4_XATTR_MAX_LARGE_EA_SIZE definition in ext4 is currently unused. > Besides, vfs enforces its own 64k limit which makes the 1MB limit in > ext4 redundant. Remove it. > > Signed-off-by: Tahsin Erdogan > --- > fs/ext4/ext4.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index 5d5fc0d0e2bc..2cdd6070e348 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -2221,12 +2221,6 @@ struct mmpd_data { > #define EXT4_MMP_MAX_CHECK_INTERVAL 300UL > > /* > - * Maximum size of xattr attributes for FEATURE_INCOMPAT_EA_INODE 1Mb > - * This limit is arbitrary, but is reasonable for the xattr API. > - */ > -#define EXT4_XATTR_MAX_LARGE_EA_SIZE (1024 * 1024) Uhhh... didn't you add this in patch 1/28? There's little point in adding a symbol just to delete it shortly thereafter. --D > - > -/* > * Function prototypes > */ > > -- > 2.13.0.219.gdb65acc882-goog >