From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 626D021A09124 for ; Wed, 31 May 2017 12:38:50 -0700 (PDT) Date: Wed, 31 May 2017 21:39:48 +0200 From: Christoph Hellwig Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid Message-ID: <20170531193948.GB6906@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> <1496254594.28981.37.camel@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1496254594.28981.37.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Andy Shevchenko Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , Amir Goldstein , linux-kernel@vger.kernel.org, Steven Whitehouse , David Howells , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Shaohua Li , Christoph Hellwig List-ID: On Wed, May 31, 2017 at 09:16:34PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > > This helper was only used by IMA of all things, which would get > > spurious > > errors if CONFIG_BLOCK is disabled.=A0=A0Just opencode the call there. > = > > - result =3D blk_part_pack_uuid(args[0].from, > > - =A0=A0=A0=A0entry->fsuuid); > > + result =3D uuid_to_bin(args[0].from, (uuid_t > > *)&entry->fsuuid); > > = > = > uuid_parse() ? Yes. I fixed this up, but it seems like I didn't squash it into the right patch.. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid Date: Wed, 31 May 2017 21:39:48 +0200 Message-ID: <20170531193948.GB6906@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> <1496254594.28981.37.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1496254594.28981.37.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Andy Shevchenko Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar , Amir Goldstein , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steven Whitehouse , David Howells , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaohua Li , Christoph Hellwig List-Id: linux-raid.ids On Wed, May 31, 2017 at 09:16:34PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > > This helper was only used by IMA of all things, which would get > > spurious > > errors if CONFIG_BLOCK is disabled.=A0=A0Just opencode the call there. > = > > - result =3D blk_part_pack_uuid(args[0].from, > > - =A0=A0=A0=A0entry->fsuuid); > > + result =3D uuid_to_bin(args[0].from, (uuid_t > > *)&entry->fsuuid); > > = > = > uuid_parse() ? Yes. I fixed this up, but it seems like I didn't squash it into the right patch.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 31 May 2017 21:39:48 +0200 From: Christoph Hellwig To: Andy Shevchenko Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid Message-ID: <20170531193948.GB6906@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> <1496254594.28981.37.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <1496254594.28981.37.camel@linux.intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, May 31, 2017 at 09:16:34PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > > This helper was only used by IMA of all things, which would get > > spurious > > errors if CONFIG_BLOCK is disabled.��Just opencode the call there. > > > - result = blk_part_pack_uuid(args[0].from, > > - ����entry->fsuuid); > > + result = uuid_to_bin(args[0].from, (uuid_t > > *)&entry->fsuuid); > > > > uuid_parse() ? Yes. I fixed this up, but it seems like I didn't squash it into the right patch.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbdEaTjw (ORCPT ); Wed, 31 May 2017 15:39:52 -0400 Received: from verein.lst.de ([213.95.11.211]:41778 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdEaTju (ORCPT ); Wed, 31 May 2017 15:39:50 -0400 Date: Wed, 31 May 2017 21:39:48 +0200 From: Christoph Hellwig To: Andy Shevchenko Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid Message-ID: <20170531193948.GB6906@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> <1496254594.28981.37.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496254594.28981.37.camel@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2017 at 09:16:34PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > > This helper was only used by IMA of all things, which would get > > spurious > > errors if CONFIG_BLOCK is disabled.  Just opencode the call there. > > > - result = blk_part_pack_uuid(args[0].from, > > -     entry->fsuuid); > > + result = uuid_to_bin(args[0].from, (uuid_t > > *)&entry->fsuuid); > > > > uuid_parse() ? Yes. I fixed this up, but it seems like I didn't squash it into the right patch.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:41778 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdEaTju (ORCPT ); Wed, 31 May 2017 15:39:50 -0400 Date: Wed, 31 May 2017 21:39:48 +0200 From: Christoph Hellwig Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid Message-ID: <20170531193948.GB6906@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> <1496254594.28981.37.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496254594.28981.37.camel@linux.intel.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Andy Shevchenko Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org On Wed, May 31, 2017 at 09:16:34PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > > This helper was only used by IMA of all things, which would get > > spurious > > errors if CONFIG_BLOCK is disabled.  Just opencode the call there. > > > - result = blk_part_pack_uuid(args[0].from, > > -     entry->fsuuid); > > + result = uuid_to_bin(args[0].from, (uuid_t > > *)&entry->fsuuid); > > > > uuid_parse() ? Yes. I fixed this up, but it seems like I didn't squash it into the right patch..