All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	lucien.xin@gmail.com, cera@cera.cz, sebott@linux.vnet.ibm.com
Subject: Re: [PATCH net] net: bridge: start hello timer only if device is up
Date: Thu, 01 Jun 2017 12:31:24 -0400 (EDT)	[thread overview]
Message-ID: <20170601.123124.646097227290806863.davem@davemloft.net> (raw)
In-Reply-To: <1496329675-11254-1-git-send-email-nikolay@cumulusnetworks.com>

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Thu,  1 Jun 2017 18:07:55 +0300

> When the transition of NO_STP -> KERNEL_STP was fixed by always calling
> mod_timer in br_stp_start, it introduced a new regression which causes
> the timer to be armed even when the bridge is down, and since we stop
> the timers in its ndo_stop() function, they never get disabled if the
> device is destroyed before it's upped.
> 
> To reproduce:
> $ while :; do ip l add br0 type bridge hello_time 100; brctl stp br0 on;
> ip l del br0; done;
> 
> CC: Xin Long <lucien.xin@gmail.com>
> CC: Ivan Vecera <cera@cera.cz>
> CC: Sebastian Ott <sebott@linux.vnet.ibm.com>
> Reported-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> Fixes: 6d18c732b95c ("bridge: start hello_timer when enabling KERNEL_STP in br_stp_start")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Applied and queued up for -stable.

  reply	other threads:[~2017-06-01 16:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 16:32 Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start Sebastian Ott
2017-06-01  7:42 ` Xin Long
2017-06-01 12:34   ` Sebastian Ott
2017-06-01 14:00     ` Nikolay Aleksandrov
2017-06-01 14:16       ` Nikolay Aleksandrov
2017-06-01 14:45         ` Nikolay Aleksandrov
2017-06-01 15:07           ` [PATCH net] net: bridge: start hello timer only if device is up Nikolay Aleksandrov
2017-06-01 16:31             ` David Miller [this message]
2017-06-01 19:44             ` Sebastian Ott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170601.123124.646097227290806863.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cera@cera.cz \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=sebott@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.