From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751118AbdFABoo (ORCPT ); Wed, 31 May 2017 21:44:44 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:42722 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbdFABon (ORCPT ); Wed, 31 May 2017 21:44:43 -0400 Date: Wed, 31 May 2017 21:44:25 -0400 From: Johannes Weiner To: Andrew Morton Cc: Josef Bacik , Michal Hocko , Vladimir Davydov , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Tony Lindgren , Russell King , Yury Norov , Stephen Rothwell Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure Message-ID: <20170601014425.GA11815@cmpxchg.org> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-6-hannes@cmpxchg.org> <20170531171450.GA10481@cmpxchg.org> <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include the following fix on top of this patch please? Thanks! > > OK. But this won't fix the init ordering crash which the arm folks are > seeing? > > I'm wondering if we should ask Stephen to drop > > mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch > mm-memcontrol-use-the-node-native-slab-memory-counters.patch > mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch > mm-memcontrol-per-lruvec-stats-infrastructure.patch > mm-memcontrol-account-slab-stats-per-lruvec.patch Sorry about the wreckage. Dropping these makes sense to me for the time being. I'll fix up the init ordering issue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 6DDFD6B0279 for ; Wed, 31 May 2017 21:44:42 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id a77so6771120wma.12 for ; Wed, 31 May 2017 18:44:42 -0700 (PDT) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id l22si17517757edj.147.2017.05.31.18.44.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 May 2017 18:44:40 -0700 (PDT) Date: Wed, 31 May 2017 21:44:25 -0400 From: Johannes Weiner Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure Message-ID: <20170601014425.GA11815@cmpxchg.org> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-6-hannes@cmpxchg.org> <20170531171450.GA10481@cmpxchg.org> <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Josef Bacik , Michal Hocko , Vladimir Davydov , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Tony Lindgren , Russell King , Yury Norov , Stephen Rothwell On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include the following fix on top of this patch please? Thanks! > > OK. But this won't fix the init ordering crash which the arm folks are > seeing? > > I'm wondering if we should ask Stephen to drop > > mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch > mm-memcontrol-use-the-node-native-slab-memory-counters.patch > mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch > mm-memcontrol-per-lruvec-stats-infrastructure.patch > mm-memcontrol-account-slab-stats-per-lruvec.patch Sorry about the wreckage. Dropping these makes sense to me for the time being. I'll fix up the init ordering issue. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure Date: Wed, 31 May 2017 21:44:25 -0400 Message-ID: <20170601014425.GA11815@cmpxchg.org> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-6-hannes@cmpxchg.org> <20170531171450.GA10481@cmpxchg.org> <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cmpxchg.org ; s=x; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JNJB3dDH9rJMsHI+P0ROqugY/bHj31krQm9X0giP4mE=; b=edSSiatVVjx61Z/703q9pzTzRr H/lYES56THZXVOPtCFcbD3zsuTtHYzROCH4M1Fp01f3xM0Cyasjq4DtzlXvbV/ZUO170XcFx7Ez3y akk7fa7RXKNhEz9CpQbeGyc+gQQuwgbdYXIo9qZg1l2YUlJ4qZLW2C8Ft5qAhja7hPFc=; Content-Disposition: inline In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Josef Bacik , Michal Hocko , Vladimir Davydov , Rik van Riel , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org, Tony Lindgren , Russell King , Yury Norov , Stephen Rothwell On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include the following fix on top of this patch please? Thanks! > > OK. But this won't fix the init ordering crash which the arm folks are > seeing? > > I'm wondering if we should ask Stephen to drop > > mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch > mm-memcontrol-use-the-node-native-slab-memory-counters.patch > mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch > mm-memcontrol-per-lruvec-stats-infrastructure.patch > mm-memcontrol-account-slab-stats-per-lruvec.patch Sorry about the wreckage. Dropping these makes sense to me for the time being. I'll fix up the init ordering issue.