From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbdFAGuc (ORCPT ); Thu, 1 Jun 2017 02:50:32 -0400 Received: from verein.lst.de ([213.95.11.211]:44513 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbdFAGub (ORCPT ); Thu, 1 Jun 2017 02:50:31 -0400 Date: Thu, 1 Jun 2017 08:50:29 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Hannes Reinecke , Max Gurtovoy , Linux NVMe Mailinglist , Linux Kernel Mailinglist Subject: Re: [PATCH v1 6/7] nvme: change magic 4096 to SZ_4K Message-ID: <20170601065029.GF16778@lst.de> References: <9d231ec2f7b34221685a305ecb02d9da884b9c08.1496237370.git.jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d231ec2f7b34221685a305ecb02d9da884b9c08.1496237370.git.jthumshirn@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As mentioned before I'd prefer a menaingful name that indicates the purpose of the constant. In fact 4096 is a lot more obvious than SZ_4K, and shortet as well :) From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 1 Jun 2017 08:50:29 +0200 Subject: [PATCH v1 6/7] nvme: change magic 4096 to SZ_4K In-Reply-To: <9d231ec2f7b34221685a305ecb02d9da884b9c08.1496237370.git.jthumshirn@suse.de> References: <9d231ec2f7b34221685a305ecb02d9da884b9c08.1496237370.git.jthumshirn@suse.de> Message-ID: <20170601065029.GF16778@lst.de> As mentioned before I'd prefer a menaingful name that indicates the purpose of the constant. In fact 4096 is a lot more obvious than SZ_4K, and shortet as well :)