From: Jiri Benc <jbenc@redhat.com>
To: Mark Bloch <markb@mellanox.com>
Cc: <roopa@cumulusnetworks.com>, <netdev@vger.kernel.org>
Subject: Re: [net] vxlan: fix use-after-free on deletion
Date: Thu, 1 Jun 2017 10:53:08 +0200 [thread overview]
Message-ID: <20170601105308.0be70eb4@griffin> (raw)
In-Reply-To: <1496306615-770-1-git-send-email-markb@mellanox.com>
On Thu, 1 Jun 2017 11:43:35 +0300, Mark Bloch wrote:
> Adding a vxlan interface to a socket isn't symmetrical, while adding
> is done in vxlan_open() the deletion is done in vxlan_dellink().
> This can cause a use-after-free error when we close the vxlan
> interface before deleting it.
>
> We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call
> it from vxlan_stop() to match the call from vxlan_open().
>
> Signed-off-by: Mark Bloch <markb@mellanox.com>
Acked-by: Jiri Benc <jbenc@redhat.com>
next prev parent reply other threads:[~2017-06-01 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 8:43 [net] vxlan: fix use-after-free on deletion Mark Bloch
2017-06-01 8:53 ` Jiri Benc [this message]
2017-06-01 11:32 ` Roi Dayan
2017-06-01 10:17 ` Or Gerlitz
2017-06-01 15:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601105308.0be70eb4@griffin \
--to=jbenc@redhat.com \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.