* [PATCH] firmware: dmi: Fix permissions of product_family
@ 2017-06-01 13:09 Jean Delvare
2017-06-01 13:13 ` Andy Shevchenko
2017-06-01 14:00 ` Mika Westerberg
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2017-06-01 13:09 UTC (permalink / raw)
To: LKML; +Cc: Dmitry Torokhov, Mika Westerberg, Andy Shevchenko, Linus Walleij
This is not sensitive information like serial numbers, we can allow
all users to read it.
Fix odd alignment while we're here.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification string")
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/firmware/dmi-id.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-4.11.orig/drivers/firmware/dmi-id.c 2017-06-01 13:49:59.933485745 +0200
+++ linux-4.11/drivers/firmware/dmi-id.c 2017-06-01 14:43:58.205186555 +0200
@@ -47,7 +47,7 @@ DEFINE_DMI_ATTR_WITH_SHOW(product_name,
DEFINE_DMI_ATTR_WITH_SHOW(product_version, 0444, DMI_PRODUCT_VERSION);
DEFINE_DMI_ATTR_WITH_SHOW(product_serial, 0400, DMI_PRODUCT_SERIAL);
DEFINE_DMI_ATTR_WITH_SHOW(product_uuid, 0400, DMI_PRODUCT_UUID);
-DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0400, DMI_PRODUCT_FAMILY);
+DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0444, DMI_PRODUCT_FAMILY);
DEFINE_DMI_ATTR_WITH_SHOW(board_vendor, 0444, DMI_BOARD_VENDOR);
DEFINE_DMI_ATTR_WITH_SHOW(board_name, 0444, DMI_BOARD_NAME);
DEFINE_DMI_ATTR_WITH_SHOW(board_version, 0444, DMI_BOARD_VERSION);
@@ -192,7 +192,7 @@ static void __init dmi_id_init_attr_tabl
ADD_DMI_ATTR(product_version, DMI_PRODUCT_VERSION);
ADD_DMI_ATTR(product_serial, DMI_PRODUCT_SERIAL);
ADD_DMI_ATTR(product_uuid, DMI_PRODUCT_UUID);
- ADD_DMI_ATTR(product_family, DMI_PRODUCT_FAMILY);
+ ADD_DMI_ATTR(product_family, DMI_PRODUCT_FAMILY);
ADD_DMI_ATTR(board_vendor, DMI_BOARD_VENDOR);
ADD_DMI_ATTR(board_name, DMI_BOARD_NAME);
ADD_DMI_ATTR(board_version, DMI_BOARD_VERSION);
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: dmi: Fix permissions of product_family
2017-06-01 13:09 [PATCH] firmware: dmi: Fix permissions of product_family Jean Delvare
@ 2017-06-01 13:13 ` Andy Shevchenko
2017-06-01 14:00 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-06-01 13:13 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML, Dmitry Torokhov, Mika Westerberg, Linus Walleij
On Thu, Jun 1, 2017 at 4:09 PM, Jean Delvare <jdelvare@suse.de> wrote:
> This is not sensitive information like serial numbers, we can allow
> all users to read it.
>
> Fix odd alignment while we're here.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Fixes: c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification string")
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/firmware/dmi-id.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-4.11.orig/drivers/firmware/dmi-id.c 2017-06-01 13:49:59.933485745 +0200
> +++ linux-4.11/drivers/firmware/dmi-id.c 2017-06-01 14:43:58.205186555 +0200
> @@ -47,7 +47,7 @@ DEFINE_DMI_ATTR_WITH_SHOW(product_name,
> DEFINE_DMI_ATTR_WITH_SHOW(product_version, 0444, DMI_PRODUCT_VERSION);
> DEFINE_DMI_ATTR_WITH_SHOW(product_serial, 0400, DMI_PRODUCT_SERIAL);
> DEFINE_DMI_ATTR_WITH_SHOW(product_uuid, 0400, DMI_PRODUCT_UUID);
> -DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0400, DMI_PRODUCT_FAMILY);
> +DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0444, DMI_PRODUCT_FAMILY);
> DEFINE_DMI_ATTR_WITH_SHOW(board_vendor, 0444, DMI_BOARD_VENDOR);
> DEFINE_DMI_ATTR_WITH_SHOW(board_name, 0444, DMI_BOARD_NAME);
> DEFINE_DMI_ATTR_WITH_SHOW(board_version, 0444, DMI_BOARD_VERSION);
> @@ -192,7 +192,7 @@ static void __init dmi_id_init_attr_tabl
> ADD_DMI_ATTR(product_version, DMI_PRODUCT_VERSION);
> ADD_DMI_ATTR(product_serial, DMI_PRODUCT_SERIAL);
> ADD_DMI_ATTR(product_uuid, DMI_PRODUCT_UUID);
> - ADD_DMI_ATTR(product_family, DMI_PRODUCT_FAMILY);
> + ADD_DMI_ATTR(product_family, DMI_PRODUCT_FAMILY);
> ADD_DMI_ATTR(board_vendor, DMI_BOARD_VENDOR);
> ADD_DMI_ATTR(board_name, DMI_BOARD_NAME);
> ADD_DMI_ATTR(board_version, DMI_BOARD_VERSION);
>
>
> --
> Jean Delvare
> SUSE L3 Support
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: dmi: Fix permissions of product_family
2017-06-01 13:09 [PATCH] firmware: dmi: Fix permissions of product_family Jean Delvare
2017-06-01 13:13 ` Andy Shevchenko
@ 2017-06-01 14:00 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2017-06-01 14:00 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML, Dmitry Torokhov, Andy Shevchenko, Linus Walleij
On Thu, Jun 01, 2017 at 03:09:26PM +0200, Jean Delvare wrote:
> This is not sensitive information like serial numbers, we can allow
> all users to read it.
>
> Fix odd alignment while we're here.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Fixes: c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification string")
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-01 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-01 13:09 [PATCH] firmware: dmi: Fix permissions of product_family Jean Delvare
2017-06-01 13:13 ` Andy Shevchenko
2017-06-01 14:00 ` Mika Westerberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.