From: Theodore Ts'o <tytso@mit.edu>
To: David Gstir <david@sigma-star.at>
Cc: Eric Biggers <ebiggers3@gmail.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Richard Weinberger <richard@sigma-star.at>,
herbert@gondor.apana.org.au, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
Daniel Walter <dwalter@sigma-star.at>
Subject: Re: [PATCH v4] fscrypt: Add support for AES-128-CBC
Date: Thu, 1 Jun 2017 10:25:30 -0400 [thread overview]
Message-ID: <20170601142530.n6rfwuwwdzmkzyfp@thunk.org> (raw)
In-Reply-To: <54DA453A-BC92-466E-B3D2-6C67D7D32A90@sigma-star.at>
On Wed, May 31, 2017 at 05:57:22PM +0200, David Gstir wrote:
> > The 'keysize > sizeof(salt)' check is now pointless and should be removed, since
> > we decided not to key the ESSIV cipher with 'keysize' bytes, but rather with
> > sizeof(salt) bytes. So this function is compatible with any 'keysize', not just
> > keysize <= sizeof(salt).
>
> You're right. Just let me know if I should send a new version of this patch with these minor issues fixed.
Please do, thanks!
- Ted
next prev parent reply other threads:[~2017-06-01 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 17:38 [PATCH] fscrypt: Add support for AES-128-CBC David Gstir
2017-03-31 6:21 ` Eric Biggers
2017-03-31 6:36 ` Eric Biggers
2017-03-31 11:11 ` David Gstir
2017-04-25 14:41 ` [PATCH v2] " David Gstir
2017-04-25 20:10 ` Eric Biggers
2017-04-26 6:18 ` David Gstir
2017-04-26 21:56 ` Eric Biggers
2017-05-17 11:21 ` [PATCH v3] " David Gstir
2017-05-17 18:08 ` Eric Biggers
2017-05-18 13:43 ` David Gstir
2017-05-18 13:43 ` David Gstir
2017-05-23 5:11 ` [PATCH v4] " David Gstir
2017-05-23 19:00 ` Eric Biggers
2017-05-31 15:57 ` David Gstir
2017-06-01 14:25 ` Theodore Ts'o [this message]
2017-06-15 20:41 ` Michael Halcrow
2017-06-15 20:48 ` Eric Biggers
2017-06-16 7:39 ` David Gstir
2017-06-19 7:27 ` [PATCH v5] " David Gstir
2017-06-24 0:09 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601142530.n6rfwuwwdzmkzyfp@thunk.org \
--to=tytso@mit.edu \
--cc=david@sigma-star.at \
--cc=dwalter@sigma-star.at \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@sigma-star.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.