From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v4 07/12] net/failsafe: support flow API
Date: Thu, 1 Jun 2017 16:28:13 +0200
Message-ID: <20170601142813.GE18840@bidouze.vm.6wind.com>
References: <cover.1495634974.git.gaetan.rivet@6wind.com>
 <cover.1496065002.git.gaetan.rivet@6wind.com>
 <36220bb3757d1764d5c054f72bfa72193a91040a.1496065002.git.gaetan.rivet@6wind.com>
 <20170531082139.5ddce6d9@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 4FF677CBD
 for <dev@dpdk.org>; Thu,  1 Jun 2017 16:28:20 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id n195so34727154wmg.1
 for <dev@dpdk.org>; Thu, 01 Jun 2017 07:28:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20170531082139.5ddce6d9@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, May 31, 2017 at 08:21:39AM -0700, Stephen Hemminger wrote:
> On Mon, 29 May 2017 15:42:19 +0200
> Gaetan Rivet <gaetan.rivet@6wind.com> wrote:
> 
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > Acked-by: Olga Shern <olgas@mellanox.com>
> > ---
> >  doc/guides/nics/features/failsafe.ini   |   1 +
> >  drivers/net/failsafe/Makefile           |   1 +
> >  drivers/net/failsafe/failsafe.c         |   1 +
> >  drivers/net/failsafe/failsafe_eal.c     |   1 +
> >  drivers/net/failsafe/failsafe_ether.c   |  70 +++++++++++
> >  drivers/net/failsafe/failsafe_flow.c    | 216 ++++++++++++++++++++++++++++++++
> >  drivers/net/failsafe/failsafe_ops.c     |  29 +++++
> >  drivers/net/failsafe/failsafe_private.h |  18 +++
> >  8 files changed, 337 insertions(+)
> >  create mode 100644 drivers/net/failsafe/failsafe_flow.c
> 
> How does this interact with typical case of VF and dumb virtual device?
> The VF has flow API but dumb virtual device does not.
> 

The fail-safe requires capabilities to be the same on all its slave. If
a capability must be supported on the VF, then is should be as well on
the synthetic path.

But the TAP PMD that can be used to capture traffic from a synthetic
path supports rte_flow in the same capacity as other NICs.

> How does this work with late binding plugin? If VF arrives later is
> the flow table reprogrammed to the VF?

The fail-safe stores an internal representation of rte_flows. These are
replayed in the same order upon plugin, so the flow table is
reprogrammed in the same way to the VF.

-- 
Gaëtan Rivet
6WIND