From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGSSu-0002l7-1H for qemu-devel@nongnu.org; Thu, 01 Jun 2017 11:56:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGSSp-0004z6-Ae for qemu-devel@nongnu.org; Thu, 01 Jun 2017 11:56:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44184) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGSSp-0004yU-1C for qemu-devel@nongnu.org; Thu, 01 Jun 2017 11:56:43 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E60031E30 for ; Thu, 1 Jun 2017 15:56:41 +0000 (UTC) Date: Thu, 1 Jun 2017 16:56:35 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170601155634.GH2845@work-vm> References: <20170531103509.22021-1-quintela@redhat.com> <20170531103509.22021-7-quintela@redhat.com> <20170601124109.GO2083@work-vm> <87wp8v7n04.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wp8v7n04.fsf@secure.mitica> Subject: Re: [Qemu-devel] [PATCH v2 06/10] migration: Export tls.c functions in its own file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quintela@redhat.com) wrote: > >> Just for the functions exported from tls.c. Notice that we can't > >> remove the migration/migration.h include from tls.c because it access > >> directly MigrationState for the tls params. > > >> +++ b/migration/tls.h > >> @@ -0,0 +1,34 @@ > >> +/* > >> + * QEMU migration TLS support > >> + * > >> + * Copyright (c) 2015 Red Hat, Inc. > >> + * > >> + * This library is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU Lesser General Public > >> + * License as published by the Free Software Foundation; either > >> + * version 2 of the License, or (at your option) any later version. > >> + * > >> + * This library is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> + * Lesser General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU Lesser General Public > >> + * License along with this library; if not, see . > >> + * > >> + */ > > > > Can you clarify why this is LGPLv2 or later please? > > Is this to follow the io/* rather than the migration/migration.h it came > > out of. > > THis is the license of tls.c > > And this are only the two functions that are exported from that file, so > .... > > And anyways, this code is posterior to the cut-off when everything new > is GPL2 or later. > > Or I am missing something? No, that's fair, I was following migration.h rather than the .c, but that's OK. Dave > Later, Juan. > > > > > > Anyway, I did see Dan's post saying it was OK to update licenses, but > > it's worth a comment in the commit message as to why. > > > > Reviewed-by: Dr. David Alan Gilbert > > > > > > Dave > > > >> + > >> +#ifndef QEMU_MIGRATION_TLS_H > >> +#define QEMU_MIGRATION_TLS_H > >> + > >> +#include "io/channel.h" > >> + > >> +void migration_tls_channel_process_incoming(MigrationState *s, > >> + QIOChannel *ioc, > >> + Error **errp); > >> + > >> +void migration_tls_channel_connect(MigrationState *s, > >> + QIOChannel *ioc, > >> + const char *hostname, > >> + Error **errp); > >> +#endif > >> -- > >> 2.9.4 > >> > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK