From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751203AbdFCOLv (ORCPT ); Sat, 3 Jun 2017 10:11:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54134 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbdFCOLu (ORCPT ); Sat, 3 Jun 2017 10:11:50 -0400 Date: Sat, 3 Jun 2017 18:11:32 +0900 From: Greg Kroah-Hartman To: Mika Westerberg Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , Lukas Wunner , Amir Levy , Andy Lutomirski , Mario.Limonciello@dell.com, Jared.Dominguez@dell.com, Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/27] thunderbolt: Convert switch to a device Message-ID: <20170603091132.GA1103@kroah.com> References: <20170602140524.23367-1-mika.westerberg@linux.intel.com> <20170602140524.23367-10-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170602140524.23367-10-mika.westerberg@linux.intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 02, 2017 at 05:05:06PM +0300, Mika Westerberg wrote: > Thunderbolt domain consists of switches that are connected to each > other, forming a bus. This will convert each switch into a real Linux > device structure and adds them to the domain. The advantage here is > that we get all the goodies from the driver core, like reference > counting and sysfs hierarchy for free. > > Also expose device identification information to the userspace via new > sysfs attributes. > > In order to support internal connection manager (ICM) we separate switch > configuration into its own function (tb_switch_configure()) which is > only called by the existing native connection manager implementation > used on Macs. > > Signed-off-by: Mika Westerberg > Reviewed-by: Yehezkel Bernat > Reviewed-by: Michael Jamet > Reviewed-by: Andy Shevchenko > --- > Documentation/ABI/testing/sysfs-bus-thunderbolt | 22 ++ > drivers/thunderbolt/eeprom.c | 2 + > drivers/thunderbolt/switch.c | 261 +++++++++++++++++++----- > drivers/thunderbolt/tb.c | 40 +++- > drivers/thunderbolt/tb.h | 45 +++- > 5 files changed, 303 insertions(+), 67 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-bus-thunderbolt For the driver model type changes, looks good to me, nice job: Acked-by: Greg Kroah-Hartman