From: David Gibson <david@gibson.dropbear.id.au>
To: Felipe Franciosi <felipe@nutanix.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Alexander Graf <agraf@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Mike Cui <cui@nutanix.com>
Subject: Re: [Qemu-devel] [PATCH] spapr: Allow boot from vhost-*-scsi backends
Date: Sat, 3 Jun 2017 21:54:44 +1000 [thread overview]
Message-ID: <20170603115444.GT13397@umbus.fritz.box> (raw)
In-Reply-To: <1496303518-25638-1-git-send-email-felipe@nutanix.com>
[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]
On Thu, Jun 01, 2017 at 08:51:58AM +0100, Felipe Franciosi wrote:
> This makes VMs bootable on spapr when using vhost-*-scsi.
This commit message needs more information: what previously prevented
vhost-*-scsi from working?
> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
> Signed-off-by: Mike Cui <cui@nutanix.com>
> ---
> hw/ppc/spapr.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index ab3aab1..1c87886 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -57,6 +57,7 @@
> #include "hw/pci/pci.h"
> #include "hw/scsi/scsi.h"
> #include "hw/virtio/virtio-scsi.h"
> +#include "hw/virtio/vhost-scsi-common.h"
>
> #include "exec/address-spaces.h"
> #include "hw/usb.h"
> @@ -2388,6 +2389,7 @@ static char *spapr_get_fw_dev_path(FWPathProvider *p, BusState *bus,
> ((type *)object_dynamic_cast(OBJECT(obj), (name)))
> SCSIDevice *d = CAST(SCSIDevice, dev, TYPE_SCSI_DEVICE);
> sPAPRPHBState *phb = CAST(sPAPRPHBState, dev, TYPE_SPAPR_PCI_HOST_BRIDGE);
> + VHostSCSICommon *vsc = CAST(VHostSCSICommon, dev, TYPE_VHOST_SCSI_COMMON);
>
> if (d) {
> void *spapr = CAST(void, bus->parent, "spapr-vscsi");
> @@ -2444,6 +2446,12 @@ static char *spapr_get_fw_dev_path(FWPathProvider *p, BusState *bus,
> return g_strdup_printf("pci@%"PRIX64, phb->buid);
> }
>
> + if (vsc) {
> + /* Same logic as virtio above */
> + unsigned id = 0x1000000 | (vsc->target << 16) | vsc->lun;
> + return g_strdup_printf("disk@%"PRIX64, (uint64_t)id << 32);
> + }
> +
> return NULL;
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-03 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 7:51 [Qemu-devel] [PATCH] spapr: Allow boot from vhost-*-scsi backends Felipe Franciosi
2017-06-03 11:54 ` David Gibson [this message]
2017-06-05 15:56 ` Felipe Franciosi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603115444.GT13397@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=cui@nutanix.com \
--cc=felipe@nutanix.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.