From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236AbdFCRjO (ORCPT ); Sat, 3 Jun 2017 13:39:14 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35517 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdFCRjL (ORCPT ); Sat, 3 Jun 2017 13:39:11 -0400 Date: Sat, 3 Jun 2017 20:39:06 +0300 From: Vladimir Davydov To: Johannes Weiner Cc: Josef Bacik , Michal Hocko , Andrew Morton , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 3/6] mm: memcontrol: use the node-native slab memory counters Message-ID: <20170603173906.GC15130@esperanza> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-4-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530181724.27197-4-hannes@cmpxchg.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 02:17:21PM -0400, Johannes Weiner wrote: > Now that the slab counters are moved from the zone to the node level > we can drop the private memcg node stats and use the official ones. > > Signed-off-by: Johannes Weiner > --- > include/linux/memcontrol.h | 2 -- > mm/memcontrol.c | 8 ++++---- > mm/slab.h | 4 ++-- > 3 files changed, 6 insertions(+), 8 deletions(-) Not sure if moving slab stats from zone to node is such a good idea, because they may be useful for identifying the reason of OOM, especially on 32 bit hosts, but provided the previous patch is accepted, this one looks good to me. Acked-by: Vladimir Davydov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f69.google.com (mail-lf0-f69.google.com [209.85.215.69]) by kanga.kvack.org (Postfix) with ESMTP id 3B6056B0292 for ; Sat, 3 Jun 2017 13:39:12 -0400 (EDT) Received: by mail-lf0-f69.google.com with SMTP id u62so16692541lfg.6 for ; Sat, 03 Jun 2017 10:39:12 -0700 (PDT) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com. [2a00:1450:4010:c07::243]) by mx.google.com with ESMTPS id o6si14954490lff.2.2017.06.03.10.39.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Jun 2017 10:39:10 -0700 (PDT) Received: by mail-lf0-x243.google.com with SMTP id f14so6771594lfe.1 for ; Sat, 03 Jun 2017 10:39:10 -0700 (PDT) Date: Sat, 3 Jun 2017 20:39:06 +0300 From: Vladimir Davydov Subject: Re: [PATCH 3/6] mm: memcontrol: use the node-native slab memory counters Message-ID: <20170603173906.GC15130@esperanza> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-4-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530181724.27197-4-hannes@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Josef Bacik , Michal Hocko , Andrew Morton , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com On Tue, May 30, 2017 at 02:17:21PM -0400, Johannes Weiner wrote: > Now that the slab counters are moved from the zone to the node level > we can drop the private memcg node stats and use the official ones. > > Signed-off-by: Johannes Weiner > --- > include/linux/memcontrol.h | 2 -- > mm/memcontrol.c | 8 ++++---- > mm/slab.h | 4 ++-- > 3 files changed, 6 insertions(+), 8 deletions(-) Not sure if moving slab stats from zone to node is such a good idea, because they may be useful for identifying the reason of OOM, especially on 32 bit hosts, but provided the previous patch is accepted, this one looks good to me. Acked-by: Vladimir Davydov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [PATCH 3/6] mm: memcontrol: use the node-native slab memory counters Date: Sat, 3 Jun 2017 20:39:06 +0300 Message-ID: <20170603173906.GC15130@esperanza> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-4-hannes@cmpxchg.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GpClLB/jB2/fRiYqz4/Qc8LRg06aLFF4cpZOm4x7hmg=; b=d3adZv9Gs87lEV4vqab3gO0lpztpjrWymAT7wY9D20ZQ7I8jRzVepp3CfJjP1JDd+c a6vqKi8SKOevtOgec6OlLLuqkq5IoWqDfBXPUDGVw1zpdz26hx26Er1eA4e6/Kg2z/JN 4cx5joiZesQR70yB4WUW0qYx5ig4BXInXJbkFp5VMOd+aZcMdmLFbvb1F7LSnieJnfdM O/2CBGd08CHEuRTF29RjCQVz+A/DG6RKL9h4D5ylZ4MWvlA3RSlf7fv4Bps8TMLi732f /35uNq/ABeo2ooGqH7r6LU5Zcwy1rxd+J02PGuKIGz7vxUg8HwbBDCx8J+GNIDHgezv6 wkQQ== Content-Disposition: inline In-Reply-To: <20170530181724.27197-4-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johannes Weiner Cc: Josef Bacik , Michal Hocko , Andrew Morton , Rik van Riel , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Tue, May 30, 2017 at 02:17:21PM -0400, Johannes Weiner wrote: > Now that the slab counters are moved from the zone to the node level > we can drop the private memcg node stats and use the official ones. > > Signed-off-by: Johannes Weiner > --- > include/linux/memcontrol.h | 2 -- > mm/memcontrol.c | 8 ++++---- > mm/slab.h | 4 ++-- > 3 files changed, 6 insertions(+), 8 deletions(-) Not sure if moving slab stats from zone to node is such a good idea, because they may be useful for identifying the reason of OOM, especially on 32 bit hosts, but provided the previous patch is accepted, this one looks good to me. Acked-by: Vladimir Davydov