From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751330AbdFEFdD (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 01:33:03 -0400
Received: from verein.lst.de ([213.95.11.211]:38000 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751249AbdFEFdC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 01:33:02 -0400
Date: Mon, 5 Jun 2017 07:33:00 +0200
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
        Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@intel.com>,
        Hannes Reinecke <hare@suse.de>, maxg@mellanox.com,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification
        Descriptor structures
Message-ID: <20170605053300.GC19480@lst.de>
References: <20170604103649.22130-1-jthumshirn@suse.de> <20170604103649.22130-2-jthumshirn@suse.de> <fda3105a-706d-0b38-6ff8-8b69749d8374@grimberg.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fda3105a-706d-0b38-6ff8-8b69749d8374@grimberg.me>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 04, 2017 at 05:59:06PM +0300, Sagi Grimberg wrote:
>>   +struct nvme_ns_identifier_hdr {
>> +	__u8 nidt;
>> +	__u8 nidl;
>> +	__le16 reserved;
>> +};
>
> Nit: _hdr is usually associated with a message or alike.
>
> Maybe nvme_ns_id_desc is more consistent with the spec language.

The descriptor itself includes the actual value, that's why
I suggested adding the _hdr prefix.  But I'm fine going either way.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Mon, 5 Jun 2017 07:33:00 +0200
Subject: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification
 Descriptor structures
In-Reply-To: <fda3105a-706d-0b38-6ff8-8b69749d8374@grimberg.me>
References: <20170604103649.22130-1-jthumshirn@suse.de>
 <20170604103649.22130-2-jthumshirn@suse.de>
 <fda3105a-706d-0b38-6ff8-8b69749d8374@grimberg.me>
Message-ID: <20170605053300.GC19480@lst.de>

On Sun, Jun 04, 2017@05:59:06PM +0300, Sagi Grimberg wrote:
>>   +struct nvme_ns_identifier_hdr {
>> +	__u8 nidt;
>> +	__u8 nidl;
>> +	__le16 reserved;
>> +};
>
> Nit: _hdr is usually associated with a message or alike.
>
> Maybe nvme_ns_id_desc is more consistent with the spec language.

The descriptor itself includes the actual value, that's why
I suggested adding the _hdr prefix.  But I'm fine going either way.