From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751326AbdFEGmu (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 02:42:50 -0400
Received: from mga14.intel.com ([192.55.52.115]:9074 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751267AbdFEGmt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 02:42:49 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,299,1493708400"; 
   d="scan'208";a="1156603747"
Date: Mon, 5 Jun 2017 09:42:30 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Amir Levy <amir.jer.levy@intel.com>, Andy Lutomirski <luto@kernel.org>,
        Mario Limonciello <Mario.Limonciello@dell.com>,
        Jared.Dominguez@dell.com,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 06/27] thunderbolt: Rework capability handling
Message-ID: <20170605064230.GI3454@lahna.fi.intel.com>
References: <20170602140524.23367-1-mika.westerberg@linux.intel.com>
 <20170602140524.23367-7-mika.westerberg@linux.intel.com>
 <20170604135229.GB7207@wunner.de>
 <20170604150002.GG3454@lahna.fi.intel.com>
 <20170604150659.GH3454@lahna.fi.intel.com>
 <CAHp75Vd01jgVX2rhi_BzMbY0c5OaJAL9LGFhX--TPjMgBg193w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vd01jgVX2rhi_BzMbY0c5OaJAL9LGFhX--TPjMgBg193w@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 04, 2017 at 09:15:03PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 4, 2017 at 6:06 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Sun, Jun 04, 2017 at 06:00:02PM +0300, Mika Westerberg wrote:
> >> On Sun, Jun 04, 2017 at 03:52:29PM +0200, Lukas Wunner wrote:
> >> > On Fri, Jun 02, 2017 at 05:05:03PM +0300, Mika Westerberg wrote:
> >> > > Organization of the capabilities in switches and ports is not so random
> >> > > after all. Rework the capability handling functionality so that it
> >> > > follows how capabilities are organized and provide two new functions
> >> > > (tb_switch_find_vsec_cap() and tb_port_find_cap()) which can be used to
> >> >                   ^^^^^^^^
> >> >
> >> > I assume VSEC is the same acronym as in the PCIe spec, so this naming
> >> > scheme results in "vendor specific extended capability capability",
> >> > which is maybe a bit odd.
> >>
> >> AFAIK it comes from Vendor SpEcifiC but I'm not 100% sure ;-) The Alpine
> >> Ridge datasheet calls it also VSEC capability which is why we chose the
> >> naming accordingly.
> >
> > That said, it could also come from Vendor SpEcific Capability. I can
> > change it to tb_switch_find_vsec() if that works better.
> 
> I would folllow PCI existing namings, i.e.
> _vse_cap()

Indeed this sounds better.

I looked at the TBT specs again and they just use VSEC but do not open
the acronym any further. I guess the "Vendor Specific Extended
Capability" as Lukas pointed out is the correct one.

I'll change the patch to use tb_switch_find_vse_cap() and rename
TB_VSEC_CAP_* to TB_VSE_CAP_* if there are no objections.