From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 29/67] drm/i915/cnl: Implement .set_cdclk() for CNL Date: Mon, 5 Jun 2017 16:11:26 +0300 Message-ID: <20170605131126.GA28137@ideak-desk.fi.intel.com> References: <1491506163-14587-1-git-send-email-rodrigo.vivi@intel.com> <1491506163-14587-29-git-send-email-rodrigo.vivi@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id D833F89BFD for ; Mon, 5 Jun 2017 13:11:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1491506163-14587-29-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDYsIDIwMTcgYXQgMTI6MTU6MjVQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+Cj4gCj4gQWRkIHN1cHBvcnQgZm9yIGNoYW5naW5nIHRoZSBjZGNsayBmcmVxdWVuY3kgb24g Q05MLiBBZ2FpbiwgcXVpdGUKPiBzaW1pbGFyIHRvIEJYVCwgYnV0IHRoZXJlIGFyZSBzb21lIGFu bm95aW5nIGRpZmZlcmVuY2VzIHdoaWNoIG1lYW5zCj4gdHJ5aW5nIHRvIHNoYXJlIG1vcmUgY29k ZSBtaWdodCBub3QgYmUgZmVhc2libGU6Cj4gKiBQTEwgcmF0aW8gbm93IGxpdmVzIGluIHRoZSBQ TEwgZW5hYmxlIHJlZ2lzdGVyCj4gKiBwY29kZSBjYW1lIGZyb20gU0tMLCBub3QgZnJvbSBCWFQK PiAKPiBXZSBzdXBwb3J0IHRocmVlIGNkY2xrIGZyZXF1ZW5jaWVzOiAxNjgsMzM2LDUyOCBNaHou IFRoZSBmaXJzdCB0d28KPiB1c2UgdGhlIHNhbWUgUExMIGZyZXF1ZW5jeSwgdGhlIGxhc3Qgb25l IHVzZXMgYSBkaWZmZXJlbnQgb25lIG1lYW5pbmcKPiB3ZSBvbmNlIGFnYWluIG1heSBuZWVkIHRv IHRvZ2dsZSB0aGUgUExMIG9mZiBhbmQgb24gd2hlbiBjaGFuZ2luZwo+IGNkY2xrLgo+IAo+IHYy OiBSZWJhc2VkIGJ5IFJvZHJpZ28gb24gdG9wIG9mIFZpbGxlJ3MgY2RjbGsgcmV3b3JrLgo+IHYz OiBSZXNwZWN0IG9yZGVyIG9mIHNldF8gYmVsbG93IGdldF8gKFZpbGxlKQo+IAo+IFNpZ25lZC1v ZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKUmV2 aWV3ZWQtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgfCAxMDUgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTA1IGluc2VydGlvbnMoKykKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiBpbmRleCBhNGUyYmQ1Li5iZWU0Mzk0IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jCj4gQEAgLTE0NTAsNiArMTQ1MCwxMTEg QEAgc3RhdGljIHZvaWQgY25sX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gIAljZGNsa19zdGF0ZS0+Y2RjbGsgPSBESVZfUk9VTkRfQ0xPU0VTVChjZGNsa19z dGF0ZS0+dmNvLCBkaXYpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBjbmxfY2RjbGtfcGxsX2Rp c2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwl1MzIgdmFs Owo+ICsKPiArCXZhbCA9IEk5MTVfUkVBRChCWFRfREVfUExMX0VOQUJMRSk7Cj4gKwl2YWwgJj0g fkJYVF9ERV9QTExfUExMX0VOQUJMRTsKPiArCUk5MTVfV1JJVEUoQlhUX0RFX1BMTF9FTkFCTEUs IHZhbCk7Cj4gKwo+ICsJLyogVGltZW91dCAyMDB1cyAqLwo+ICsJaWYgKHdhaXRfZm9yKChJOTE1 X1JFQUQoQlhUX0RFX1BMTF9FTkFCTEUpICYgQlhUX0RFX1BMTF9MT0NLKSA9PSAwLCAxKSkKPiAr CQlEUk1fRVJST1IoInRpbW91dCB3YWl0aW5nIGZvciBDRENMSyBQTEwgdW5sb2NrXG4iKTsKPiAr Cj4gKwlkZXZfcHJpdi0+Y2RjbGsuaHcudmNvID0gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQg Y25sX2NkY2xrX3BsbF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBp bnQgdmNvKQo+ICt7Cj4gKwlpbnQgcmF0aW8gPSBESVZfUk9VTkRfQ0xPU0VTVCh2Y28sIGRldl9w cml2LT5jZGNsay5ody5yZWYpOwo+ICsJdTMyIHZhbDsKPiArCj4gKwl2YWwgPSBDTkxfQ0RDTEtf UExMX1JBVElPKHJhdGlvKTsKPiArCUk5MTVfV1JJVEUoQlhUX0RFX1BMTF9FTkFCTEUsIHZhbCk7 Cj4gKwo+ICsJdmFsIHw9IEJYVF9ERV9QTExfUExMX0VOQUJMRTsKPiArCUk5MTVfV1JJVEUoQlhU X0RFX1BMTF9FTkFCTEUsIHZhbCk7Cj4gKwo+ICsJLyogVGltZW91dCAyMDB1cyAqLwo+ICsJaWYg KHdhaXRfZm9yKChJOTE1X1JFQUQoQlhUX0RFX1BMTF9FTkFCTEUpICYgQlhUX0RFX1BMTF9MT0NL KSAhPSAwLCAxKSkKPiArCQlEUk1fRVJST1IoInRpbW91dCB3YWl0aW5nIGZvciBDRENMSyBQTEwg bG9ja1xuIik7Cj4gKwo+ICsJZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyA9IHZjbzsKPiArfQo+ICsK PiArc3RhdGljIHZvaWQgY25sX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gKwkJCSAgY29uc3Qgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0 ZSkKPiArewo+ICsJaW50IGNkY2xrID0gY2RjbGtfc3RhdGUtPmNkY2xrOwo+ICsJaW50IHZjbyA9 IGNkY2xrX3N0YXRlLT52Y287Cj4gKwl1MzIgdmFsLCBkaXZpZGVyLCBwY3VfYWNrOwo+ICsJaW50 IHJldDsKPiArCj4gKwltdXRleF9sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spOwo+ICsJcmV0 ID0gc2tsX3Bjb2RlX3JlcXVlc3QoZGV2X3ByaXYsIFNLTF9QQ09ERV9DRENMS19DT05UUk9MLAo+ ICsJCQkJU0tMX0NEQ0xLX1BSRVBBUkVfRk9SX0NIQU5HRSwKPiArCQkJCVNLTF9DRENMS19SRUFE WV9GT1JfQ0hBTkdFLAo+ICsJCQkJU0tMX0NEQ0xLX1JFQURZX0ZPUl9DSEFOR0UsIDMpOwo+ICsJ bXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spOwo+ICsJaWYgKHJldCkgewo+ICsJ CURSTV9FUlJPUigiRmFpbGVkIHRvIGluZm9ybSBQQ1UgYWJvdXQgY2RjbGsgY2hhbmdlICglZClc biIsCj4gKwkJCSAgcmV0KTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJLyogY2RjbGsgPSB2 Y28gLyAyIC8gZGl2ezEsMn0gKi8KPiArCXN3aXRjaCAoRElWX1JPVU5EX0NMT1NFU1QodmNvLCBj ZGNsaykpIHsKPiArCWNhc2UgNDoKPiArCQlkaXZpZGVyID0gQlhUX0NEQ0xLX0NEMlhfRElWX1NF TF8yOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAyOgo+ICsJCWRpdmlkZXIgPSBCWFRfQ0RDTEtfQ0Qy WF9ESVZfU0VMXzE7Cj4gKwkJYnJlYWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCVdBUk5fT04oY2RjbGsg IT0gZGV2X3ByaXYtPmNkY2xrLmh3LnJlZik7Cj4gKwkJV0FSTl9PTih2Y28gIT0gMCk7Cj4gKwo+ ICsJCWRpdmlkZXIgPSBCWFRfQ0RDTEtfQ0QyWF9ESVZfU0VMXzE7Cj4gKwkJYnJlYWs7Cj4gKwl9 Cj4gKwo+ICsJc3dpdGNoIChjZGNsaykgewo+ICsJY2FzZSA1MjgwMDA6Cj4gKwkJcGN1X2FjayA9 IDI7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDMzNjAwMDoKPiArCQlwY3VfYWNrID0gMTsKPiArCQli cmVhazsKPiArCWNhc2UgMTY4MDAwOgo+ICsJZGVmYXVsdDoKPiArCQlwY3VfYWNrID0gMDsKPiAr CQlicmVhazsKPiArCX0KPiArCj4gKwlpZiAoZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyAhPSAwICYm Cj4gKwkgICAgZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyAhPSB2Y28pCj4gKwkJY25sX2NkY2xrX3Bs bF9kaXNhYmxlKGRldl9wcml2KTsKPiArCj4gKwlpZiAoZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyAh PSB2Y28pCj4gKwkJY25sX2NkY2xrX3BsbF9lbmFibGUoZGV2X3ByaXYsIHZjbyk7Cj4gKwo+ICsJ dmFsID0gZGl2aWRlciB8IHNrbF9jZGNsa19kZWNpbWFsKGNkY2xrKTsKPiArCS8qCj4gKwkgKiBG SVhNRSBpZiBvbmx5IHRoZSBjZDJ4IGRpdmlkZXIgbmVlZHMgY2hhbmdpbmcsIGl0IGNvdWxkIGJl IGRvbmUKPiArCSAqIHdpdGhvdXQgc2h1dHRpbmcgb2ZmIHRoZSBwaXBlIChpZiBvbmx5IG9uZSBw aXBlIGlzIGFjdGl2ZSkuCj4gKwkgKi8KPiArCXZhbCB8PSBCWFRfQ0RDTEtfQ0QyWF9QSVBFX05P TkU7Cj4gKwlJOTE1X1dSSVRFKENEQ0xLX0NUTCwgdmFsKTsKPiArCj4gKwkvKiBpbmZvcm0gUENV IG9mIHRoZSBjaGFuZ2UgKi8KPiArCW11dGV4X2xvY2soJmRldl9wcml2LT5ycHMuaHdfbG9jayk7 Cj4gKwlzYW5keWJyaWRnZV9wY29kZV93cml0ZShkZXZfcHJpdiwgU0tMX1BDT0RFX0NEQ0xLX0NP TlRST0wsIHBjdV9hY2spOwo+ICsJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2sp Owo+ICsKPiArCWludGVsX3VwZGF0ZV9jZGNsayhkZXZfcHJpdik7Cj4gK30KPiArCj4gIC8qKgo+ ICAgKiBpbnRlbF9jZGNsa19zdGF0ZV9jb21wYXJlIC0gRGV0ZXJtaW5lIGlmIHR3byBDRENMSyBz dGF0ZXMgZGlmZmVyCj4gICAqIEBhOiBmaXJzdCBDRENMSyBzdGF0ZQo+IC0tIAo+IDEuOS4xCj4g Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=