All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] lib/igt_debugfs: Only use valid values in igt_crc_to_str()
Date: Mon,  5 Jun 2017 14:28:40 +0100	[thread overview]
Message-ID: <20170605132840.9125-5-liviu.dudau@arm.com> (raw)
In-Reply-To: <20170605132840.9125-1-liviu.dudau@arm.com>

From: Brian Starkey <brian.starkey@arm.com>

Not all elements in the crc array may be valid, so only use the valid
ones to generate the string.

Signed-off-by: Brian Starkey <brian.starkey@arm.com>
---
 lib/igt_debugfs.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index f5ed3daf..80f25c61 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -312,10 +312,11 @@ void igt_assert_crc_equal(const igt_crc_t *a, const igt_crc_t *b)
  */
 char *igt_crc_to_string(igt_crc_t *crc)
 {
-	char buf[128];
+	int i;
+	char buf[128] = { 0 };
 
-	sprintf(buf, "%08x %08x %08x %08x %08x", crc->crc[0],
-		crc->crc[1], crc->crc[2], crc->crc[3], crc->crc[4]);
+	for (i = 0; i < crc->n_words; i++)
+		sprintf(buf + strlen(buf), "%08x ", crc->crc[i]);
 
 	return strdup(buf);
 }
-- 
2.13.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-06-05 13:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 13:28 [PATCH 0/4] Cleanups and fixes Liviu Dudau
2017-06-05 13:28 ` [PATCH 1/4] lib/igt_kms: Fix erroneous assert Liviu Dudau
2017-06-06 10:32   ` Arkadiusz Hiler
2017-06-05 13:28 ` [PATCH 2/4] lib/igt_kms: Fix override_mode handling Liviu Dudau
2017-06-06 10:30   ` Arkadiusz Hiler
2017-06-06 10:54     ` Liviu Dudau
2017-06-16 14:00     ` [PATCH v2] " Liviu Dudau
2017-06-20 13:28       ` Arkadiusz Hiler
2017-06-20 15:22         ` Liviu Dudau
2017-06-05 13:28 ` [PATCH 3/4] lib/igt_debugfs: Remove igt_debugfs_t Liviu Dudau
2017-06-06 10:37   ` Arkadiusz Hiler
2017-06-05 13:28 ` Liviu Dudau [this message]
2017-06-06 11:06   ` [PATCH 4/4] lib/igt_debugfs: Only use valid values in igt_crc_to_str() Arkadiusz Hiler
2017-06-09 12:34 ` [PATCH 0/4] Cleanups and fixes Arkadiusz Hiler
2017-06-09 12:37   ` Arkadiusz Hiler
2017-06-09 12:47     ` Liviu Dudau
2017-06-12 10:33     ` Liviu Dudau
2017-06-16 11:08       ` Arkadiusz Hiler
2017-06-16 11:34         ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170605132840.9125-5-liviu.dudau@arm.com \
    --to=liviu.dudau@arm.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.