All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 1/2] lvm2: add host package
Date: Mon, 5 Jun 2017 15:33:34 +0200	[thread overview]
Message-ID: <20170605153334.3cbccffe@free-electrons.com> (raw)
In-Reply-To: <20170522134015.54040-1-Vincent.Riera@imgtec.com>

Hello,

On Mon, 22 May 2017 14:40:14 +0100, Vicente Olivert Riera wrote:

> +HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install

This is wrong. Host installation should basically *never* use DESTDIR,
but prefix instead. Since our autotools-package infrastructure already
passes --prefix=$(HOST_DIR)/usr, you shouldn't have to override to
override the HOST_LVM2_INSTALL_OPTS.

But, this patch is in fact not needed. I'll reply on PATCH 2/2 why.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2017-06-05 13:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 13:40 [Buildroot] [PATCH next 1/2] lvm2: add host package Vicente Olivert Riera
2017-05-22 13:40 ` [Buildroot] [PATCH next 2/2] parted: bump version to 3.2 Vicente Olivert Riera
2017-05-24  2:11   ` Matthew Weber
2017-05-26 15:22     ` Matthew Weber
2017-06-05 13:44   ` Thomas Petazzoni
2017-05-26 15:23 ` [Buildroot] [PATCH next 1/2] lvm2: add host package Matthew Weber
2017-06-05 13:33 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170605153334.3cbccffe@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.