From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751266AbdFEPnQ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 11:43:16 -0400
Received: from mga14.intel.com ([192.55.52.115]:35648 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751171AbdFEPnP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 11:43:15 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,300,1493708400"; 
   d="scan'208";a="976958925"
Date: Mon, 5 Jun 2017 18:40:57 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lukas Wunner <lukas@wunner.de>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Amir Levy <amir.jer.levy@intel.com>, Andy Lutomirski <luto@kernel.org>,
        Mario.Limonciello@dell.com, Jared.Dominguez@dell.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs
Message-ID: <20170605154057.GQ3454@lahna.fi.intel.com>
References: <20170602140524.23367-1-mika.westerberg@linux.intel.com>
 <20170602140524.23367-20-mika.westerberg@linux.intel.com>
 <20170605081437.GA7519@wunner.de>
 <20170605093249.GK3454@lahna.fi.intel.com>
 <20170605120756.GA7793@wunner.de>
 <20170605125507.GL3454@lahna.fi.intel.com>
 <20170605133334.GM3454@lahna.fi.intel.com>
 <1496672494.22624.4.camel@linux.intel.com>
 <20170605152036.GA19810@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170605152036.GA19810@kroah.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 05, 2017 at 05:20:36PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote:
> > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote:
> > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote:
> > > > > 
> > 
> > > It turns out that this is not too big change after all so I think it
> > > can
> > > be included in the ICM patch if you want.
> > > 
> > > Basically we would have module parameter:
> > > 
> > > 	cm=auto|native|icm
> > > 
> > > where auto is the default.
> > > 
> > > Does that work?
> > 
> > 
> > I remember Greg is opposite to being fan of module parameters in new
> > code, so, please, if you are still going to do that, do it a separate
> > patch which will be last in the series and can be discussed separately
> > w.o. preventing everything else being applied.
> 
> Yes, you should never need module parameters in "modern" code.  As no
> one will ever set them, or know what to do here.  Make it "automatic"
> please.

Well in current series it is already automatic :-)

What Lukas wants here is a way to force a certain connection manager
implementation to be used instead.