From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751308AbdFEUG6 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 16:06:58 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:34596 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751189AbdFEUG4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 16:06:56 -0400
Date: Mon, 5 Jun 2017 13:06:52 -0700
From: Eric Biggers <ebiggers3@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "# 3.4.x" <stable@vger.kernel.org>,
        Philip =?iso-8859-1?Q?M=FCller?= <philm@manjaro.org>,
        Daniel Micay <danielmicay@gmail.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Rik van Riel <riel@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "kernel-hardening@lists.openwall.com" 
        <kernel-hardening@lists.openwall.com>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [kernel-hardening] Re: [PATCH 3.18 01/33] Revert
 "stackprotector: Increase the per-task stack canarys random range from 32
 bits to 64 bits on 64-bit platforms"
Message-ID: <20170605200652.GB87699@gmail.com>
References: <20170605153020.953645204@linuxfoundation.org>
 <20170605153021.008595891@linuxfoundation.org>
 <CAGXu5jKQ63WOrPMMCVfvRueV2D=YnXAgUGm7zWU+hBSkVDmVwQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5jKQ63WOrPMMCVfvRueV2D=YnXAgUGm7zWU+hBSkVDmVwQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 05, 2017 at 12:13:11PM -0700, Kees Cook wrote:
> On Mon, Jun 5, 2017 at 9:16 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > 3.18-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > This reverts commit 609a3e81550b0b4ea87197b0f59455a7bcff975a which is
> > commit 5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05 upstream.
> >
> > It shouldn't have been backported to 3.18, as we do not have
> > get_random_long() in that kernel tree.
> 
> It should be possible to trivially backport
> ec9ee4acd97c0039a61c0ae4f12705767ae62153 to gain get_random_long().
> 
> -Kees

If that's done it may be a good idea to take
b1132deac01c2332d234fa821a70022796b79182 as well, which fixed an alignment bug
in get_random_long().

Eric