From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbdFEX2Z (ORCPT ); Mon, 5 Jun 2017 19:28:25 -0400 Received: from mail.fastquake.com ([45.33.83.177]:54128 "EHLO mail.fastquake.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdFEX2W (ORCPT ); Mon, 5 Jun 2017 19:28:22 -0400 Date: Mon, 5 Jun 2017 23:28:19 +0000 From: John Brooks To: Joe Perches Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkpatch: Change format of --color argument to --color[=WHEN] Message-ID: <20170605232819.GA1775@kitsune.fastquake.com> References: <1496701622-1465-1-git-send-email-john@fastquake.com> <1496704230.1968.5.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496704230.1968.5.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 05, 2017 at 04:10:30PM -0700, Joe Perches wrote: > On Mon, 2017-06-05 at 18:27 -0400, John Brooks wrote: > > The boolean --color argument did not offer the ability to force colourized > > output even if stdout is not a terminal. > > OK, but why is colorizing output not to terminals desired? For example, to retain coloured output when using a pager (such as less -R). Which is convenient for viewing/searching lengthy output from larger patch sets, or when one is using something that interferes with the ability to scroll such as screen, tmux, or mosh. > > > Change the format of the argument > > to the familiar --color[=WHEN] construct as seen in common Linux utilities > > such as ls and dmesg, which allows the user to specify whether to colourize > > output always, never, or only when the output is a terminal ("auto"). > > > > Because the option is no longer boolean, --nocolor (or --no-color) is no > > longer available. Users of the old negative option should use --color=never > > instead. > > In general, I don't mind, but perhaps this option name > could/should change. > > As is, this also causes a previous command line that worked > with --color to fail > > $ ./scripts/checkpatch.pl --color foo.patch > Invalid color mode: foo.patch > Oh, that's pretty bad. I should have thought of that, sorry. I'll see what I can do to stop it from eating other arguments. -- John Brooks