All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@infradead.org>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Szymon Mielczarek <szymonx.mielczarek@intel.com>,
	Michal Potomski <michalx.potomski@intel.com>,
	Grzegorz Janca <grzegorz.janca@intel.com>
Subject: Re: [PATCH V3 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers
Date: Tue, 6 Jun 2017 03:10:34 -0700	[thread overview]
Message-ID: <20170606101034.GA20599@infradead.org> (raw)
In-Reply-To: <1496740136-4024-1-git-send-email-adrian.hunter@intel.com>


This looks much better.  But the new file still looks almost like
a copy and paste of tc-dwc-g210-pci.c.  Wouldnt it make more sense to
start with a common ufshcd-pci driver that sets up the ufs_hba_variant_opsA
based on the PCI ID table?

Also given that this almost entitrely a copy & paste job of
tc-dwc-g210-pci.c. you should add the copyrights and following their
license.

      reply	other threads:[~2017-06-06 10:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05  8:36 [PATCH 0/2] scsi: ufs: Add PCI driver for Intel Host controllers Adrian Hunter
2017-06-05  8:36 ` [PATCH 1/2] scsi: ufs: Tidy clocks list head usage Adrian Hunter
2017-06-05 20:37   ` Subhash Jadavani
2017-06-06  0:57   ` Martin K. Petersen
2017-06-05  8:36 ` [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Adrian Hunter
2017-06-05 20:42   ` Subhash Jadavani
2017-06-06  6:48     ` [PATCH V2 1/2] scsi: ufs: Tidy clocks list head usage Adrian Hunter
2017-06-06  6:48       ` [PATCH V2 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Adrian Hunter
2017-06-06  6:50       ` [PATCH V2 1/2] scsi: ufs: Tidy clocks list head usage Adrian Hunter
2017-06-06  7:07   ` [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Christoph Hellwig
2017-06-06  9:08     ` [PATCH V3 " Adrian Hunter
2017-06-06 10:10       ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606101034.GA20599@infradead.org \
    --to=hch@infradead.org \
    --cc=adrian.hunter@intel.com \
    --cc=grzegorz.janca@intel.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michalx.potomski@intel.com \
    --cc=szymonx.mielczarek@intel.com \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.