From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v2 17/25] KVM: arm64: Enable GICv3 Group-0 sysreg trapping via command-line Date: Tue, 6 Jun 2017 14:44:36 +0200 Message-ID: <20170606124436.GP9464@cbox> References: <20170601102117.17750-1-marc.zyngier@arm.com> <20170601102117.17750-18-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoffer Dall , David Daney , Catalin Marinas , Mark Rutland , Robert Richter , Eric Auger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org To: Marc Zyngier Return-path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:34900 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbdFFMov (ORCPT ); Tue, 6 Jun 2017 08:44:51 -0400 Received: by mail-wm0-f47.google.com with SMTP id x70so36255464wme.0 for ; Tue, 06 Jun 2017 05:44:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170601102117.17750-18-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 01, 2017 at 11:21:09AM +0100, Marc Zyngier wrote: > Now that we're able to safely handle Group-0 sysreg access, let's > give the user the opportunity to enable it by passing a specific > command-line option (vgic_v3.group0_trap). > > Signed-off-by: Marc Zyngier > --- > virt/kvm/arm/vgic/vgic-v3.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/virt/kvm/arm/vgic/vgic-v3.c b/virt/kvm/arm/vgic/vgic-v3.c > index 7525216ef988..1486ce25edcb 100644 > --- a/virt/kvm/arm/vgic/vgic-v3.c > +++ b/virt/kvm/arm/vgic/vgic-v3.c > @@ -419,6 +419,12 @@ int vgic_v3_map_resources(struct kvm *kvm) > > DEFINE_STATIC_KEY_FALSE(vgic_v3_cpuif_trap); > > +static int __init early_group0_trap_cfg(char *buf) > +{ > + return strtobool(buf, &group0_trap); > +} > +early_param("vgic_v3.group0_trap", early_group0_trap_cfg); > + same comment as before, if this should be called something with KVM. Also, btw., what's the policy on adding new kernel parameters? Should they be documented in kernel-parameters.txt or is that auto-generated these days? Thanks, -Christoffer > static int __init early_group1_trap_cfg(char *buf) > { > return strtobool(buf, &group1_trap); > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: cdall@linaro.org (Christoffer Dall) Date: Tue, 6 Jun 2017 14:44:36 +0200 Subject: [PATCH v2 17/25] KVM: arm64: Enable GICv3 Group-0 sysreg trapping via command-line In-Reply-To: <20170601102117.17750-18-marc.zyngier@arm.com> References: <20170601102117.17750-1-marc.zyngier@arm.com> <20170601102117.17750-18-marc.zyngier@arm.com> Message-ID: <20170606124436.GP9464@cbox> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 01, 2017 at 11:21:09AM +0100, Marc Zyngier wrote: > Now that we're able to safely handle Group-0 sysreg access, let's > give the user the opportunity to enable it by passing a specific > command-line option (vgic_v3.group0_trap). > > Signed-off-by: Marc Zyngier > --- > virt/kvm/arm/vgic/vgic-v3.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/virt/kvm/arm/vgic/vgic-v3.c b/virt/kvm/arm/vgic/vgic-v3.c > index 7525216ef988..1486ce25edcb 100644 > --- a/virt/kvm/arm/vgic/vgic-v3.c > +++ b/virt/kvm/arm/vgic/vgic-v3.c > @@ -419,6 +419,12 @@ int vgic_v3_map_resources(struct kvm *kvm) > > DEFINE_STATIC_KEY_FALSE(vgic_v3_cpuif_trap); > > +static int __init early_group0_trap_cfg(char *buf) > +{ > + return strtobool(buf, &group0_trap); > +} > +early_param("vgic_v3.group0_trap", early_group0_trap_cfg); > + same comment as before, if this should be called something with KVM. Also, btw., what's the policy on adding new kernel parameters? Should they be documented in kernel-parameters.txt or is that auto-generated these days? Thanks, -Christoffer > static int __init early_group1_trap_cfg(char *buf) > { > return strtobool(buf, &group1_trap); > -- > 2.11.0 >