From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751489AbdFFNvY (ORCPT ); Tue, 6 Jun 2017 09:51:24 -0400 Received: from one.firstfloor.org ([193.170.194.197]:50822 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbdFFNvX (ORCPT ); Tue, 6 Jun 2017 09:51:23 -0400 Date: Tue, 6 Jun 2017 06:51:20 -0700 From: Andi Kleen To: Peter Zijlstra Cc: Andi Kleen , acme@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, Andi Kleen , Stephane Eranian Subject: Re: [PATCH 2/6] perf/x86: Fix data source decoding for Skylake Message-ID: <20170606135120.GG8096@two.firstfloor.org> References: <20170605224838.11759-1-andi@firstfloor.org> <20170605224838.11759-2-andi@firstfloor.org> <20170606100822.fds5qmgimz74jfja@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606100822.fds5qmgimz74jfja@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Not too happy about that.. > > P(LVLX, L4) | P(LVLX, REMOTE) > > reads like something that should be PERF_MEM_LVL_REM_CCE1 or something CCE1? You mean L4? The two bits seem cleaner to me than enumerating all cases. But ok. REM_L4 > This new generic 'REMOTE' has too much overlap with the existing things. So you want a REM_NA ? -Andi