Hi Tobias,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc4 next-20170606]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Alan-Tull/patches-for-fpga/20170606-072535
config: m32r-allyesconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m32r
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:329:0,
from include/linux/kernel.h:13,
from include/linux/delay.h:21,
from drivers/fpga/altera-freeze-bridge.c:18:
drivers/fpga/altera-freeze-bridge.c: In function 'altera_freeze_br_do_freeze':
>> drivers/fpga/altera-freeze-bridge.c:108:15: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int' [-Wformat=]
dev_dbg(dev, "%s %d %d\n", __func__, status, readl(csr_ctrl_addr));
^
include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~
>> drivers/fpga/altera-freeze-bridge.c:108:2: note: in expansion of macro 'dev_dbg'
dev_dbg(dev, "%s %d %d\n", __func__, status, readl(csr_ctrl_addr));
^~~~~~~
drivers/fpga/altera-freeze-bridge.c: In function 'altera_freeze_br_do_unfreeze':
drivers/fpga/altera-freeze-bridge.c:145:15: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int' [-Wformat=]
dev_dbg(dev, "%s %d %d\n", __func__, status, readl(csr_ctrl_addr));
^
include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~
drivers/fpga/altera-freeze-bridge.c:145:2: note: in expansion of macro 'dev_dbg'
dev_dbg(dev, "%s %d %d\n", __func__, status, readl(csr_ctrl_addr));
^~~~~~~
drivers/fpga/altera-freeze-bridge.c:163:15: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int' [-Wformat=]
dev_dbg(dev, "%s %d %d\n", __func__, status, readl(csr_ctrl_addr));
^
include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~
drivers/fpga/altera-freeze-bridge.c:163:2: note: in expansion of macro 'dev_dbg'
dev_dbg(dev, "%s %d %d\n", __func__, status, readl(csr_ctrl_addr));
^~~~~~~
vim +108 drivers/fpga/altera-freeze-bridge.c
ca24a648 Alan Tull 2016-11-01 12 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
ca24a648 Alan Tull 2016-11-01 13 * more details.
ca24a648 Alan Tull 2016-11-01 14 *
ca24a648 Alan Tull 2016-11-01 15 * You should have received a copy of the GNU General Public License along with
ca24a648 Alan Tull 2016-11-01 16 * this program. If not, see .
ca24a648 Alan Tull 2016-11-01 17 */
ca24a648 Alan Tull 2016-11-01 @18 #include
ca24a648 Alan Tull 2016-11-01 19 #include
ca24a648 Alan Tull 2016-11-01 20 #include
ca24a648 Alan Tull 2016-11-01 21 #include
ca24a648 Alan Tull 2016-11-01 22 #include
ca24a648 Alan Tull 2016-11-01 23 #include
ca24a648 Alan Tull 2016-11-01 24
ca24a648 Alan Tull 2016-11-01 25 #define FREEZE_CSR_STATUS_OFFSET 0
ca24a648 Alan Tull 2016-11-01 26 #define FREEZE_CSR_CTRL_OFFSET 4
ca24a648 Alan Tull 2016-11-01 27 #define FREEZE_CSR_ILLEGAL_REQ_OFFSET 8
ca24a648 Alan Tull 2016-11-01 28 #define FREEZE_CSR_REG_VERSION 12
ca24a648 Alan Tull 2016-11-01 29
ca24a648 Alan Tull 2016-11-01 30 #define FREEZE_CSR_SUPPORTED_VERSION 2
dd17cc7b Matthew Gerlach 2017-04-24 31 #define FREEZE_CSR_OFFICIAL_VERSION 0xad000003
ca24a648 Alan Tull 2016-11-01 32
ca24a648 Alan Tull 2016-11-01 33 #define FREEZE_CSR_STATUS_FREEZE_REQ_DONE BIT(0)
ca24a648 Alan Tull 2016-11-01 34 #define FREEZE_CSR_STATUS_UNFREEZE_REQ_DONE BIT(1)
ca24a648 Alan Tull 2016-11-01 35
ca24a648 Alan Tull 2016-11-01 36 #define FREEZE_CSR_CTRL_FREEZE_REQ BIT(0)
ca24a648 Alan Tull 2016-11-01 37 #define FREEZE_CSR_CTRL_RESET_REQ BIT(1)
ca24a648 Alan Tull 2016-11-01 38 #define FREEZE_CSR_CTRL_UNFREEZE_REQ BIT(2)
ca24a648 Alan Tull 2016-11-01 39
ca24a648 Alan Tull 2016-11-01 40 #define FREEZE_BRIDGE_NAME "freeze"
ca24a648 Alan Tull 2016-11-01 41
ca24a648 Alan Tull 2016-11-01 42 struct altera_freeze_br_data {
ca24a648 Alan Tull 2016-11-01 43 struct device *dev;
ca24a648 Alan Tull 2016-11-01 44 void __iomem *base_addr;
ca24a648 Alan Tull 2016-11-01 45 bool enable;
ca24a648 Alan Tull 2016-11-01 46 };
ca24a648 Alan Tull 2016-11-01 47
ca24a648 Alan Tull 2016-11-01 48 /*
ca24a648 Alan Tull 2016-11-01 49 * Poll status until status bit is set or we have a timeout.
ca24a648 Alan Tull 2016-11-01 50 */
ca24a648 Alan Tull 2016-11-01 51 static int altera_freeze_br_req_ack(struct altera_freeze_br_data *priv,
ca24a648 Alan Tull 2016-11-01 52 u32 timeout, u32 req_ack)
ca24a648 Alan Tull 2016-11-01 53 {
ca24a648 Alan Tull 2016-11-01 54 struct device *dev = priv->dev;
ca24a648 Alan Tull 2016-11-01 55 void __iomem *csr_illegal_req_addr = priv->base_addr +
ca24a648 Alan Tull 2016-11-01 56 FREEZE_CSR_ILLEGAL_REQ_OFFSET;
ca24a648 Alan Tull 2016-11-01 57 u32 status, illegal, ctrl;
ca24a648 Alan Tull 2016-11-01 58 int ret = -ETIMEDOUT;
ca24a648 Alan Tull 2016-11-01 59
ca24a648 Alan Tull 2016-11-01 60 do {
ca24a648 Alan Tull 2016-11-01 61 illegal = readl(csr_illegal_req_addr);
ca24a648 Alan Tull 2016-11-01 62 if (illegal) {
ca24a648 Alan Tull 2016-11-01 63 dev_err(dev, "illegal request detected 0x%x", illegal);
ca24a648 Alan Tull 2016-11-01 64
ca24a648 Alan Tull 2016-11-01 65 writel(1, csr_illegal_req_addr);
ca24a648 Alan Tull 2016-11-01 66
ca24a648 Alan Tull 2016-11-01 67 illegal = readl(csr_illegal_req_addr);
ca24a648 Alan Tull 2016-11-01 68 if (illegal)
ca24a648 Alan Tull 2016-11-01 69 dev_err(dev, "illegal request not cleared 0x%x",
ca24a648 Alan Tull 2016-11-01 70 illegal);
ca24a648 Alan Tull 2016-11-01 71
ca24a648 Alan Tull 2016-11-01 72 ret = -EINVAL;
ca24a648 Alan Tull 2016-11-01 73 break;
ca24a648 Alan Tull 2016-11-01 74 }
ca24a648 Alan Tull 2016-11-01 75
ca24a648 Alan Tull 2016-11-01 76 status = readl(priv->base_addr + FREEZE_CSR_STATUS_OFFSET);
ca24a648 Alan Tull 2016-11-01 77 dev_dbg(dev, "%s %x %x\n", __func__, status, req_ack);
ca24a648 Alan Tull 2016-11-01 78 status &= req_ack;
ca24a648 Alan Tull 2016-11-01 79 if (status) {
ca24a648 Alan Tull 2016-11-01 80 ctrl = readl(priv->base_addr + FREEZE_CSR_CTRL_OFFSET);
ca24a648 Alan Tull 2016-11-01 81 dev_dbg(dev, "%s request %x acknowledged %x %x\n",
ca24a648 Alan Tull 2016-11-01 82 __func__, req_ack, status, ctrl);
ca24a648 Alan Tull 2016-11-01 83 ret = 0;
ca24a648 Alan Tull 2016-11-01 84 break;
ca24a648 Alan Tull 2016-11-01 85 }
ca24a648 Alan Tull 2016-11-01 86
ca24a648 Alan Tull 2016-11-01 87 udelay(1);
ca24a648 Alan Tull 2016-11-01 88 } while (timeout--);
ca24a648 Alan Tull 2016-11-01 89
ca24a648 Alan Tull 2016-11-01 90 if (ret == -ETIMEDOUT)
ca24a648 Alan Tull 2016-11-01 91 dev_err(dev, "%s timeout waiting for 0x%x\n",
ca24a648 Alan Tull 2016-11-01 92 __func__, req_ack);
ca24a648 Alan Tull 2016-11-01 93
ca24a648 Alan Tull 2016-11-01 94 return ret;
ca24a648 Alan Tull 2016-11-01 95 }
ca24a648 Alan Tull 2016-11-01 96
ca24a648 Alan Tull 2016-11-01 97 static int altera_freeze_br_do_freeze(struct altera_freeze_br_data *priv,
ca24a648 Alan Tull 2016-11-01 98 u32 timeout)
ca24a648 Alan Tull 2016-11-01 99 {
ca24a648 Alan Tull 2016-11-01 100 struct device *dev = priv->dev;
ca24a648 Alan Tull 2016-11-01 101 void __iomem *csr_ctrl_addr = priv->base_addr +
ca24a648 Alan Tull 2016-11-01 102 FREEZE_CSR_CTRL_OFFSET;
ca24a648 Alan Tull 2016-11-01 103 u32 status;
ca24a648 Alan Tull 2016-11-01 104 int ret;
ca24a648 Alan Tull 2016-11-01 105
ca24a648 Alan Tull 2016-11-01 106 status = readl(priv->base_addr + FREEZE_CSR_STATUS_OFFSET);
ca24a648 Alan Tull 2016-11-01 107
ca24a648 Alan Tull 2016-11-01 @108 dev_dbg(dev, "%s %d %d\n", __func__, status, readl(csr_ctrl_addr));
ca24a648 Alan Tull 2016-11-01 109
ca24a648 Alan Tull 2016-11-01 110 if (status & FREEZE_CSR_STATUS_FREEZE_REQ_DONE) {
ca24a648 Alan Tull 2016-11-01 111 dev_dbg(dev, "%s bridge already disabled %d\n",
:::::: The code at line 108 was first introduced by commit
:::::: ca24a648f535a02b4163ca4f4d2e51869f155a3a fpga: add altera freeze bridge support
:::::: TO: Alan Tull
:::::: CC: Greg Kroah-Hartman
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation