From: Scott Bauer <scott.bauer@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Tejun Heo <tj@kernel.org>,
Jonathan Derrick <jonathan.derrick@intel.com>,
Rafael Antognolli <rafael.antognolli@intel.com>,
Robert Elliott <elliott@hpe.com>,
linux-ide@vger.kernel.org, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks
Date: Tue, 6 Jun 2017 15:40:07 -0600 [thread overview]
Message-ID: <20170606214007.zx66c7rogeylptx6@sbauer-Z170X-UD5> (raw)
In-Reply-To: <20170606095955.GC20590@lst.de>
On Tue, Jun 06, 2017 at 11:59:55AM +0200, Christoph Hellwig wrote:
> On Mon, Jun 05, 2017 at 03:15:31PM -0600, Scott Bauer wrote:
> > I'm not familiar at all with ATA, but I noticed there was no unlock from suspend support
> > in the series. Does ATA not have a way to determine if we're coming out of a suspend?
>
> I don't know, and not having a test system with a OPAL capable driver
> and suspend support I could not even test the code.
>
> > I see there are some power-ops in scsi/sd.c, if you do want to add it you can mabe toss a
> >
> > if (sdkp->security)
> > opal_unlock_from_suspend(sdpk->opal_dev)
> >
> > somewhere in the resume path? We handle null opal_devs and no unlock from suspend list
> > so calling it when nothing is set up is just a no-op.
>
> Yeah, maybe. We'll just need someone who could test it first.
I was given a sata drive that apparently has opal enabled on it. If it actually has opal
I can run some tests.
next prev parent reply other threads:[~2017-06-06 21:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 12:42 TCG Opal support for libata Christoph Hellwig
2017-06-04 12:42 ` [PATCH 1/6] libata: move ata_read_log_page to libata-core.c Christoph Hellwig
2017-06-06 6:27 ` Hannes Reinecke
2017-06-04 12:42 ` [PATCH 2/6] libata: factor out a ata_log_supported helper Christoph Hellwig
2017-06-06 6:28 ` Hannes Reinecke
2017-06-04 12:42 ` [PATCH 3/6] libata: clarify log page naming / grouping Christoph Hellwig
2017-06-06 6:29 ` Hannes Reinecke
2017-06-04 12:42 ` [PATCH 4/6] libata: factor out a ata_identify_page_supported helper Christoph Hellwig
2017-06-05 12:46 ` Sergei Shtylyov
2017-06-06 6:29 ` Hannes Reinecke
2017-06-04 12:42 ` [PATCH 5/6] libata: implement SECURITY PROTOCOL IN/OUT Christoph Hellwig
2017-06-06 6:30 ` Hannes Reinecke
2017-06-04 12:42 ` [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks Christoph Hellwig
2017-06-05 21:15 ` Scott Bauer
2017-06-06 9:59 ` Christoph Hellwig
2017-06-06 21:40 ` Scott Bauer [this message]
2017-06-06 0:48 ` Martin K. Petersen
2017-06-06 9:58 ` Christoph Hellwig
2017-06-13 6:40 ` Christoph Hellwig
2017-06-13 15:19 ` Martin K. Petersen
2017-06-06 6:31 ` Hannes Reinecke
2017-06-05 19:30 ` TCG Opal support for libata Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606214007.zx66c7rogeylptx6@sbauer-Z170X-UD5 \
--to=scott.bauer@intel.com \
--cc=elliott@hpe.com \
--cc=hch@lst.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rafael.antognolli@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.