From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] new package: ratpoison
Date: Tue, 6 Jun 2017 23:01:36 +0200 [thread overview]
Message-ID: <20170606230136.7240eb7a@free-electrons.com> (raw)
In-Reply-To: <20170601143349.5406-1-mrugiero@gmail.com>
Hello,
I've applied, after doing a number of fixes.
First, the commit title should have been "ratpoison: new package".
On Thu, 1 Jun 2017 11:33:49 -0300, Mario J. Rugiero wrote:
> diff --git a/package/ratpoison/ratpoison.mk b/package/ratpoison/ratpoison.mk
> new file mode 100644
> index 000000000..18222c217
> --- /dev/null
> +++ b/package/ratpoison/ratpoison.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# ratpoison
> +#
> +################################################################################
> +
> +RATPOISON_VERSION = 1.4.9
> +RATPOISON_SOURCE = ratpoison-$(RATPOISON_VERSION).tar.xz
> +RATPOISON_SITE = http://download.savannah.nongnu.org/releases/ratpoison
> +RATPOISON_LICENSE = GPL-2.0
The license really was GPL-2.0+, not GPL-2.0.
> +RATPOISON_LICENSE_FILES = COPYING
> +
> +RATPOISON_CONF_OPTS = --x-includes=$(STAGING_DIR)/usr/include/X11 \
> + --x-libraries=$(STAGING_DIR)/usr/lib
Indentation on the second line should be done with just one tab. And
also, explicitly disabling options not handled is a good practice. So
in the end, this looked like this:
+RATPOISON_CONF_OPTS = \
+ --x-includes=$(STAGING_DIR)/usr/include/X11 \
+ --x-libraries=$(STAGING_DIR)/usr/lib \
+ --without-xkb \
+ --without-xft
If you want to send another patch to optionally enable XKB and XFT
support, that would be welcome.
> +ifeq ($(BR2_PACKAGE_XLIB_LIBXRANDR),y)
> + RATPOISON_DEPENDENCIES += xlib_libXrandr
> + RATPOISON_CONF_OPTS += --with-xrandr
Do not indent such variable definitions.
Applied with those fixes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-06 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 22:02 [Buildroot] [PATCH] new package: ratpoison Mario J. Rugiero
2017-06-01 8:37 ` Thomas Petazzoni
2017-06-01 14:33 ` [Buildroot] [PATCH v2] " Mario J. Rugiero
2017-06-06 21:01 ` Thomas Petazzoni [this message]
2017-06-06 23:02 ` Mario Rugiero
2017-06-07 15:03 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606230136.7240eb7a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.