From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbdFFWJQ (ORCPT ); Tue, 6 Jun 2017 18:09:16 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:54777 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbdFFWJO (ORCPT ); Tue, 6 Jun 2017 18:09:14 -0400 Date: Wed, 7 Jun 2017 00:09:11 +0200 From: Boris Brezillon To: Masahiro Yamada Cc: linux-mtd@lists.infradead.org, Enrico Jorns , Artem Bityutskiy , Dinh Nguyen , Marek Vasut , Graham Moore , David Woodhouse , Masami Hiramatsu , Chuanxiao Dong , Jassi Brar , Cyrille Pitchen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris , Richard Weinberger , Rob Herring , Mark Rutland Subject: Re: [PATCH v4 00/23] mtd: nand: denali: Denali NAND IP patch bomb Message-ID: <20170607000911.521d559d@bbrezillon> In-Reply-To: <1496704922-12261-1-git-send-email-yamada.masahiro@socionext.com> References: <1496704922-12261-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On Tue, 6 Jun 2017 08:21:39 +0900 Masahiro Yamada wrote: > This patch series intends to solve various problems. > > [1] The driver just retrieves the OOB area as-is > whereas the controller uses syndrome page layout. > [2] Many NAND chip specific parameters are hard-coded in the driver. > [3] ONFi devices are not working > [4] It can not read Bad Block Marker > > Outstanding changes are: > - Fix raw/oob callbacks for syndrome page layout > - Implement setup_data_interface() callback > - Fix/implement more commands for ONFi devices > - Allow to skip the driver internal bounce buffer > - Support PIO in case DMA is not supported > - Switch from ->cmdfunc over to ->cmd_ctrl > > 18 patches were merged at v2. > 11 patches were merged at v3. > Here is the rest of the series. > > v1: https://lkml.org/lkml/2016/11/26/144 > v2: https://lkml.org/lkml/2017/3/22/804 > v3: https://lkml.org/lkml/2017/3/30/90 > > > Masahiro Yamada (23): > mtd: nand: denali_dt: clean up resource ioremap > mtd: nand: denali: use BIT() and GENMASK() for register macros > mtd: nand: add generic helpers to check, match, maximize ECC settings > mtd: nand: denali: avoid hard-coding ECC step, strength, bytes > mtd: nand: denali: remove Toshiba and Hynix specific fixup code > mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants > mtd: nand: denali: set NAND_ECC_CUSTOM_PAGE_ACCESS > mtd: nand: denali: do not propagate NAND_STATUS_FAIL to waitfunc() > mtd: nand: denali: remove unneeded find_valid_banks() > mtd: nand: denali: handle timing parameters by setup_data_interface() > mtd: nand: denali: rework interrupt handling > mtd: nand: denali: fix NAND_CMD_STATUS handling > mtd: nand: denali: fix NAND_CMD_PARAM handling > mtd: nand: denali: switch over to cmd_ctrl instead of cmdfunc > mtd: nand: denali: fix bank reset function to detect the number of > chips > mtd: nand: denali: use interrupt instead of polling for bank reset > mtd: nand: denali: propagate page to helpers via function argument > mtd: nand: denali: merge struct nand_buf into struct denali_nand_info > mtd: nand: denali: use flag instead of register macro for direction > mtd: nand: denali: fix raw and oob accessors for syndrome page layout > mtd: nand: denali: skip driver internal bounce buffer when possible > mtd: nand: denali: use non-managed kmalloc() for DMA buffer > mtd: nand: denali: enable bad block table scan I'd like to apply as much patches as possible from this series (already applied patches 1 and 2). Can you point patches that actually depend on patches 3 and 4? > > .../devicetree/bindings/mtd/denali-nand.txt | 13 + > drivers/mtd/nand/denali.c | 1701 +++++++++----------- > drivers/mtd/nand/denali.h | 294 ++-- > drivers/mtd/nand/denali_dt.c | 54 +- > drivers/mtd/nand/denali_pci.c | 15 +- > drivers/mtd/nand/nand_base.c | 219 +++ > include/linux/mtd/nand.h | 35 + > 7 files changed, 1235 insertions(+), 1096 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v4 00/23] mtd: nand: denali: Denali NAND IP patch bomb Date: Wed, 7 Jun 2017 00:09:11 +0200 Message-ID: <20170607000911.521d559d@bbrezillon> References: <1496704922-12261-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1496704922-12261-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Masahiro Yamada Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Enrico Jorns , Artem Bityutskiy , Dinh Nguyen , Marek Vasut , Graham Moore , David Woodhouse , Masami Hiramatsu , Chuanxiao Dong , Jassi Brar , Cyrille Pitchen , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Brian Norris , Richard Weinberger , Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org Hi Masahiro, On Tue, 6 Jun 2017 08:21:39 +0900 Masahiro Yamada wrote: > This patch series intends to solve various problems. > > [1] The driver just retrieves the OOB area as-is > whereas the controller uses syndrome page layout. > [2] Many NAND chip specific parameters are hard-coded in the driver. > [3] ONFi devices are not working > [4] It can not read Bad Block Marker > > Outstanding changes are: > - Fix raw/oob callbacks for syndrome page layout > - Implement setup_data_interface() callback > - Fix/implement more commands for ONFi devices > - Allow to skip the driver internal bounce buffer > - Support PIO in case DMA is not supported > - Switch from ->cmdfunc over to ->cmd_ctrl > > 18 patches were merged at v2. > 11 patches were merged at v3. > Here is the rest of the series. > > v1: https://lkml.org/lkml/2016/11/26/144 > v2: https://lkml.org/lkml/2017/3/22/804 > v3: https://lkml.org/lkml/2017/3/30/90 > > > Masahiro Yamada (23): > mtd: nand: denali_dt: clean up resource ioremap > mtd: nand: denali: use BIT() and GENMASK() for register macros > mtd: nand: add generic helpers to check, match, maximize ECC settings > mtd: nand: denali: avoid hard-coding ECC step, strength, bytes > mtd: nand: denali: remove Toshiba and Hynix specific fixup code > mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants > mtd: nand: denali: set NAND_ECC_CUSTOM_PAGE_ACCESS > mtd: nand: denali: do not propagate NAND_STATUS_FAIL to waitfunc() > mtd: nand: denali: remove unneeded find_valid_banks() > mtd: nand: denali: handle timing parameters by setup_data_interface() > mtd: nand: denali: rework interrupt handling > mtd: nand: denali: fix NAND_CMD_STATUS handling > mtd: nand: denali: fix NAND_CMD_PARAM handling > mtd: nand: denali: switch over to cmd_ctrl instead of cmdfunc > mtd: nand: denali: fix bank reset function to detect the number of > chips > mtd: nand: denali: use interrupt instead of polling for bank reset > mtd: nand: denali: propagate page to helpers via function argument > mtd: nand: denali: merge struct nand_buf into struct denali_nand_info > mtd: nand: denali: use flag instead of register macro for direction > mtd: nand: denali: fix raw and oob accessors for syndrome page layout > mtd: nand: denali: skip driver internal bounce buffer when possible > mtd: nand: denali: use non-managed kmalloc() for DMA buffer > mtd: nand: denali: enable bad block table scan I'd like to apply as much patches as possible from this series (already applied patches 1 and 2). Can you point patches that actually depend on patches 3 and 4? > > .../devicetree/bindings/mtd/denali-nand.txt | 13 + > drivers/mtd/nand/denali.c | 1701 +++++++++----------- > drivers/mtd/nand/denali.h | 294 ++-- > drivers/mtd/nand/denali_dt.c | 54 +- > drivers/mtd/nand/denali_pci.c | 15 +- > drivers/mtd/nand/nand_base.c | 219 +++ > include/linux/mtd/nand.h | 35 + > 7 files changed, 1235 insertions(+), 1096 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html