From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751872AbdFGJtr (ORCPT ); Wed, 7 Jun 2017 05:49:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37180 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdFGJtm (ORCPT ); Wed, 7 Jun 2017 05:49:42 -0400 Date: Wed, 7 Jun 2017 11:49:31 +0200 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Imre Deak , Bjorn Helgaas , "Rafael J. Wysocki" Subject: Re: [PATCH 4.4 39/53] PCI/PM: Add needs_resume flag to avoid suspend complete optimization Message-ID: <20170607094931.GA9052@kroah.com> References: <20170605153037.105331684@linuxfoundation.org> <20170605153039.759752532@linuxfoundation.org> <1496765970.1989.11.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496765970.1989.11.camel@codethink.co.uk> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2017 at 05:19:30PM +0100, Ben Hutchings wrote: > On Mon, 2017-06-05 at 18:17 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Imre Deak > > > > commit 4d071c3238987325b9e50e33051a40d1cce311cc upstream. > > > > Some drivers - like i915 - may not support the system suspend direct > > complete optimization due to differences in their runtime and system > > suspend sequence. Add a flag that when set resumes the device before > > calling the driver's system suspend handlers which effectively disables > > the optimization. > > > > Needed by a future patch fixing suspend/resume on i915. > > The patch for i915 isn't in this series, or even in mainline yet, so I > don't think this belongs in stable yet. Also, based on the commit > message (commit adfdf85d795f "drm/i915: Prevent the system suspend > complete optimization") it appears that only 4.8 and later are affected > by the bug. Thanks for digging into this, I was kind of curious about it, but I thought it was fixing an old issue. I've now dropped this from all stable queues. greg k-h