[PATCH] scsi: remove useless variable assignment

["Gustavo A. R. Silva" <garsilva@embeddedor.com>]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]


Remove both variable assignments once the value stored in variable _reqlen_
is overwritten at some point either by line 2321: reqlen = mptr - msg;
or by line 2330: reqlen = 12;

Addresses-Coverity-ID: 1226930
Addresses-Coverity-ID: 1226931
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
  drivers/scsi/dpt_i2o.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 256dd67..acad668 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -2292,11 +2292,8 @@ static s32 adpt_scsi_to_i2o(adpt_hba* pHba,  
struct scsi_cmnd* cmd, struct adpt_d
  	mptr+=4;
  	lenptr=mptr++;		/* Remember me - fill in when we know */
  	if (dpt_dma64(pHba)) {
-		reqlen = 16;		// SINGLE SGE
  		*mptr++ = (0x7C<<24)+(2<<16)+0x02; /* Enable 64 bit */
  		*mptr++ = 1 << PAGE_SHIFT;
-	} else {
-		reqlen = 14;		// SINGLE SGE
  	}
  	/* Now fill in the SGList and command */

--
2.5.0





[-- Attachment #2: Forwarded Message --]
[-- Type: message/rfc822, Size: 2121 bytes --]

From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Adaptec OEM Raid Solutions <aacraid@adaptec.com>, "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH] scsi: remove useless variable assignment
Date: Wed, 17 May 2017 20:00:32 -0500
Message-ID: <20170518010032.GA12354@embeddedgus>

Remove both variable assignments once the value stored in variable _reqlen_
is overwritten at some point either by line 2321: reqlen = mptr - msg;
or by line 2330: reqlen = 12;

Addresses-Coverity-ID: 1226930
Addresses-Coverity-ID: 1226931
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/scsi/dpt_i2o.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 256dd67..acad668 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -2292,11 +2292,8 @@ static s32 adpt_scsi_to_i2o(adpt_hba* pHba, struct scsi_cmnd* cmd, struct adpt_d
 	mptr+=4;
 	lenptr=mptr++;		/* Remember me - fill in when we know */
 	if (dpt_dma64(pHba)) {
-		reqlen = 16;		// SINGLE SGE
 		*mptr++ = (0x7C<<24)+(2<<16)+0x02; /* Enable 64 bit */
 		*mptr++ = 1 << PAGE_SHIFT;
-	} else {
-		reqlen = 14;		// SINGLE SGE
 	}
 	/* Now fill in the SGList and command */
 
-- 
2.5.0