From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751786AbdFHHmW (ORCPT ); Thu, 8 Jun 2017 03:42:22 -0400 Received: from verein.lst.de ([213.95.11.211]:57419 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbdFHHmV (ORCPT ); Thu, 8 Jun 2017 03:42:21 -0400 Date: Thu, 8 Jun 2017 09:42:19 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Hannes Reinecke , Max Gurtovoy , Linux NVMe Mailinglist , Linux Kernel Mailinglist Subject: Re: [PATCH v6 02/10] nvmet: use NVME_IDENTIFY_DATA_SIZE Message-ID: <20170608074219.GB13953@lst.de> References: <20170607094536.32419-1-jthumshirn@suse.de> <20170607094536.32419-3-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170607094536.32419-3-jthumshirn@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good, but we should also use this for BUILD_BUG_ON checks on the identify payloads, bug I can fix that up. Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 8 Jun 2017 09:42:19 +0200 Subject: [PATCH v6 02/10] nvmet: use NVME_IDENTIFY_DATA_SIZE In-Reply-To: <20170607094536.32419-3-jthumshirn@suse.de> References: <20170607094536.32419-1-jthumshirn@suse.de> <20170607094536.32419-3-jthumshirn@suse.de> Message-ID: <20170608074219.GB13953@lst.de> Looks good, but we should also use this for BUILD_BUG_ON checks on the identify payloads, bug I can fix that up. Reviewed-by: Christoph Hellwig