All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, thomas.monjalon@6wind.com, shreyansh.jain@nxp.com,
	stable@dpdk.org
Subject: Re: [PATCH 1/2] test/test_mbuf: Remove mempool global var
Date: Thu, 8 Jun 2017 12:08:16 +0200	[thread overview]
Message-ID: <20170608120816.48c25965@platinum> (raw)
In-Reply-To: <20170511103044.14298-1-santosh.shukla@caviumnetworks.com>

Hi Santosh,

On Thu, 11 May 2017 16:00:43 +0530, Santosh Shukla <santosh.shukla@caviumnetworks.com> wrote:
> Cc: stable@dpdk.org
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
>  test/test/test_mbuf.c | 100 +++++++++++++++++++++++++-------------------------
>  1 file changed, 51 insertions(+), 49 deletions(-)
> 

Thank you for doing this fix.

My only comment is that commit introduces a memory leak, which
is fixed by your second patch.

The behavior before your patch was to allocate the pools once
but never free them.
The behavior after this patch is to allocate the pools each time
the test is started and never free them.

After your 2 patches, the behavior is good.
So I suggest to merge them into one commit. What do you think?


Olivier

  parent reply	other threads:[~2017-06-08 10:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11 10:30 [PATCH 1/2] test/test_mbuf: Remove mempool global var Santosh Shukla
2017-05-11 10:30 ` [PATCH 2/2] test/test_mbuf: Free mempool on exit Santosh Shukla
2017-06-05  5:07   ` santosh
2017-06-05  5:04 ` [PATCH 1/2] test/test_mbuf: Remove mempool global var santosh
2017-06-08 10:08 ` Olivier Matz [this message]
2017-06-08 11:21   ` santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608120816.48c25965@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=stable@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.