From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbdFIJ4H (ORCPT ); Fri, 9 Jun 2017 05:56:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49046 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdFIJ4G (ORCPT ); Fri, 9 Jun 2017 05:56:06 -0400 Date: Fri, 9 Jun 2017 11:55:47 +0200 From: Greg Kroah-Hartman To: Sebastian Reichel Cc: Evgeniy Polyakov , "Andrew F. Davis" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface Message-ID: <20170609095547.GA26558@kroah.com> References: <20170605135208.24807-1-afd@ti.com> <20170605135208.24807-2-afd@ti.com> <56941496682285@web32j.yandex.ru> <20170608121940.wydtrbstglx7tcdx@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170608121940.wydtrbstglx7tcdx@earth> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2017 at 02:19:40PM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, Jun 05, 2017 at 08:04:45PM +0300, Evgeniy Polyakov wrote: > > 05.06.2017, 16:52, "Andrew F. Davis" : > > > Like other subsystems we should be able to define slave devices outside > > > of the w1 directory. To do this we move public facing interface > > > definitions to include/linux/w1.h and rename the internal definition > > > file to w1_internal.h. > > > > > > As w1_family.h and w1_int.h contained almost entirely public > > > driver interface definitions we simply removed these files and > > > moved the remaining definitions into w1_internal.h. > > > > > > With this we can now start to move slave devices out of w1/slaves and > > > into the subsystem based on the function they implement, again like > > > other drivers. > > > > > > Signed-off-by: Andrew F. Davis > > > Reviewed-by: Sebastian Reichel > > > > Thank you, looks good to me. > > > > Acked-by: Evgeniy Polyakov > > > > Greg, please pull it into your tree > > It would be nice, if I can get an immutable branch for > the power-supply subsystem to ease merge process of > MAX1721x driver. Once it moves into my char-misc-next branch, it will be immutable. Give it a day or so... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Fri, 09 Jun 2017 09:55:47 +0000 Subject: Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface Message-Id: <20170609095547.GA26558@kroah.com> List-Id: References: <20170605135208.24807-1-afd@ti.com> <20170605135208.24807-2-afd@ti.com> <56941496682285@web32j.yandex.ru> <20170608121940.wydtrbstglx7tcdx@earth> In-Reply-To: <20170608121940.wydtrbstglx7tcdx@earth> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sebastian Reichel Cc: Evgeniy Polyakov , "Andrew F. Davis" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Thu, Jun 08, 2017 at 02:19:40PM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, Jun 05, 2017 at 08:04:45PM +0300, Evgeniy Polyakov wrote: > > 05.06.2017, 16:52, "Andrew F. Davis" : > > > Like other subsystems we should be able to define slave devices outside > > > of the w1 directory. To do this we move public facing interface > > > definitions to include/linux/w1.h and rename the internal definition > > > file to w1_internal.h. > > > > > > As w1_family.h and w1_int.h contained almost entirely public > > > driver interface definitions we simply removed these files and > > > moved the remaining definitions into w1_internal.h. > > > > > > With this we can now start to move slave devices out of w1/slaves and > > > into the subsystem based on the function they implement, again like > > > other drivers. > > > > > > Signed-off-by: Andrew F. Davis > > > Reviewed-by: Sebastian Reichel > > > > Thank you, looks good to me. > > > > Acked-by: Evgeniy Polyakov > > > > Greg, please pull it into your tree > > It would be nice, if I can get an immutable branch for > the power-supply subsystem to ease merge process of > MAX1721x driver. Once it moves into my char-misc-next branch, it will be immutable. Give it a day or so... thanks, greg k-h