From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbdFIKuE (ORCPT ); Fri, 9 Jun 2017 06:50:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:42916 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751809AbdFIKuB (ORCPT ); Fri, 9 Jun 2017 06:50:01 -0400 Date: Fri, 9 Jun 2017 12:49:47 +0200 From: Michal Hocko To: Wei Yang Cc: Andrew Morton , Linux-MM , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Balbir Singh , Dan Williams , Heiko Carstens , Martin Schwidefsky , Tobias Regnery , Yasuaki Ishimatsu Subject: Re: [PATCH -v4 0/14] mm: make movable onlining suck less Message-ID: <20170609104947.GD21764@dhcp22.suse.cz> References: <20170515085827.16474-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 09-06-17 17:51:24, Wei Yang wrote: > Hi, Michal > > I am not that familiar with hotplug and trying to catch up the issue > and your solution. > > One potential issue I found is we don't check the physical boundary > when add_memory_resource(). > > For example, on x86-64, only 64T physical memory is supported currently. > Looks it is expanded after 5-level pagetable is introduced. While there is > still some limitations on this. But we don't check the boundary I think. > > During the bootup, this is ensured by the max_pfn which is guaranteed to > be under MAX_ARCH_PFN. I don't see some limitation on this when doing > hotplug. This might be true and I would have to double check but this rework doesn't change anything in that regards. Or do I miss something? -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 4C2766B0311 for ; Fri, 9 Jun 2017 06:49:52 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id a3so5351773wma.12 for ; Fri, 09 Jun 2017 03:49:52 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id t20si776335wra.224.2017.06.09.03.49.50 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 09 Jun 2017 03:49:51 -0700 (PDT) Date: Fri, 9 Jun 2017 12:49:47 +0200 From: Michal Hocko Subject: Re: [PATCH -v4 0/14] mm: make movable onlining suck less Message-ID: <20170609104947.GD21764@dhcp22.suse.cz> References: <20170515085827.16474-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Wei Yang Cc: Andrew Morton , Linux-MM , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Balbir Singh , Dan Williams , Heiko Carstens , Martin Schwidefsky , Tobias Regnery , Yasuaki Ishimatsu On Fri 09-06-17 17:51:24, Wei Yang wrote: > Hi, Michal > > I am not that familiar with hotplug and trying to catch up the issue > and your solution. > > One potential issue I found is we don't check the physical boundary > when add_memory_resource(). > > For example, on x86-64, only 64T physical memory is supported currently. > Looks it is expanded after 5-level pagetable is introduced. While there is > still some limitations on this. But we don't check the boundary I think. > > During the bootup, this is ensured by the max_pfn which is guaranteed to > be under MAX_ARCH_PFN. I don't see some limitation on this when doing > hotplug. This might be true and I would have to double check but this rework doesn't change anything in that regards. Or do I miss something? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org