From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751590AbdFINoJ (ORCPT ); Fri, 9 Jun 2017 09:44:09 -0400 Received: from sym2.noone.org ([178.63.92.236]:49271 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbdFINoH (ORCPT ); Fri, 9 Jun 2017 09:44:07 -0400 Date: Fri, 9 Jun 2017 15:44:03 +0200 From: Tobias Klauser To: Greg Kroah-Hartman Cc: Alan Tull , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, Moritz Fischer , delicious.quinoa@gmail.com Subject: Re: [PATCH 03/10] fpga: allow to compile-test Altera FPGA bridge drivers Message-ID: <20170609134403.GB14372@distanz.ch> References: <20170605190741.10508-1-atull@kernel.org> <20170605190741.10508-4-atull@kernel.org> <20170609094902.GA17360@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170609094902.GA17360@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-06-09 at 11:49:02 +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 05, 2017 at 02:07:34PM -0500, Alan Tull wrote: > > From: Tobias Klauser > > > > Add COMPILE_TEST to the Kconfig entry for the Altera SoCFPGA FPGA > > Bridge. The Altera FPGA Freeze Bridge can also be used on Altera PEIe > > FPGAs, so the driver shouldn't depend on ARCH_SOCFPGA in the first place. > > This allows test-compiling the drivers on other architectures to catch > > compiler errors/warnings, e.g. due to API/header changes earlier on. > > > > Signed-off-by: Tobias Klauser > > Signed-off-by: Alan Tull > > --- > > drivers/fpga/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > I'll drop this patch from the series, as kbuild reports errors with it > :( These are warnings from the m32r cross compiler, not errors. They are due to the way readl() is defined on m32r (returning unsigned long instead of u32, as all other architectures do, see [1]). On all other architectures the patch doesn't cause any issues. There are also other cases which are already in mainline where this issue appers, so I'd say this patch rather uncovers the symptom of a problem rather than causing it ;) [1] https://marc.info/?l=linux-kernel&m=149252925326414