From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v2 07/12] pdump: disabled by default
Date: Sun, 11 Jun 2017 21:42:25 +0200
Message-ID: <20170611194225.GO29091@bidouze.vm.6wind.com>
References: <cover.1496877060.git.gaetan.rivet@6wind.com>
 <87a12a85ab782a5995100ea1e2ae80a2c7e0ec5e.1496877060.git.gaetan.rivet@6wind.com>
 <3AEA2BF9852C6F48A459DA490692831F2A2133A4@irsmsx110.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id CFB231075
 for <dev@dpdk.org>; Sun, 11 Jun 2017 21:42:35 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id v111so76546506wrc.3
 for <dev@dpdk.org>; Sun, 11 Jun 2017 12:42:35 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2133A4@irsmsx110.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Reshma,

On Fri, Jun 09, 2017 at 02:24:58PM +0000, Pattan, Reshma wrote:
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet
> > Sent: Thursday, June 8, 2017 12:59 AM
> > To: dev@dpdk.org
> > Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
> > Subject: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default
> > 
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> >  config/common_base | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/config/common_base b/config/common_base index
> > cade611..8ec5e4e 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -700,7 +700,7 @@ CONFIG_RTE_KNI_PREEMPT_DEFAULT=y  #  # Compile
> > the pdump library  # -CONFIG_RTE_LIBRTE_PDUMP=y
> > +CONFIG_RTE_LIBRTE_PDUMP=n
> > 
> >  #
> >  # Compile vhost user library
> > --
> > 2.1.4
> 
> Since, you already mentioned in other mail to Ferruh that config flag disabling patches are only for testers compilation purpose and you have plans to make proper fix by end of June.  I will wait on for actual patch. 
> 

I said I planned to do so, but found out that I would not have enough
time before the end of June. Sorry about the ambiguous phrasing.

Do you think you will be able to fix this library in time?

> Please see if rte_pci.h can be removed from the includes of rte_pdump.c , might be unnecessary include.
> 
> Thanks,
> Reshma

-- 
Gaëtan Rivet
6WIND