From: David Sterba <dsterba@suse.cz>
To: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] Btrfs: btrfs_ioctl_search_key documentation
Date: Mon, 12 Jun 2017 18:31:01 +0200 [thread overview]
Message-ID: <20170612163101.GT25451@twin.jikos.cz> (raw)
In-Reply-To: <0555ff61-2c1d-1de2-0978-fb82f1a64979@mendix.com>
On Mon, Jun 12, 2017 at 06:03:15PM +0200, Hans van Kranenburg wrote:
> >> Most interesting changes since v1:
> >> - mention the special tree_id input value 0
> >> - rewrite the part about min_key and max_key, trying to be more concise
> >
> > I find the description instructive enough so the expanded expression to
> > describe the whole range is not IMHO needed.
>
> You mean drop the extra line "All metadata..." ? Yeah, it's a bit
> redudant, stressing the fact, yes.
Ah, sorry I was not clear. I was referring to Goffredo's proposal with
the expression how the min_key and max_key are calculated. Your text in
v2 is fine. We know how to calculate one key and we know the where are
the limits.
> The main purpose is to stop users from thinking that setting min_type
> and max_type will filter the returned objects (like, only getting
> BLOCK_GROUP_ITEM_KEY or so). So as long as you think that's clear
> enough, I'm ok with anything.
The text looks good to me and I've added the patch to the queue. Further
refinements are welcome.
prev parent reply other threads:[~2017-06-12 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 15:27 [PATCH] Btrfs: Improve btrfs_ioctl_search_key documentation Hans van Kranenburg
2017-06-05 16:03 ` Hans van Kranenburg
2017-06-05 19:00 ` Goffredo Baroncelli
2017-06-05 22:16 ` Hans van Kranenburg
2017-06-05 22:20 ` [PATCH v2] Btrfs: " Hans van Kranenburg
2017-06-12 15:38 ` David Sterba
2017-06-12 16:03 ` Hans van Kranenburg
2017-06-12 16:31 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612163101.GT25451@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=hans.van.kranenburg@mendix.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.