From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq Date: Mon, 12 Jun 2017 19:10:21 -0700 Message-ID: <20170613021021.GS20170@codeaurora.org> References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-15-git-send-email-kgunda@codeaurora.org> <20170531175330.GE20170@codeaurora.org> <644a2fd1dc36c3fd4ee5cd7f835c41a9@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41394 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753122AbdFMCKX (ORCPT ); Mon, 12 Jun 2017 22:10:23 -0400 Content-Disposition: inline In-Reply-To: <644a2fd1dc36c3fd4ee5cd7f835c41a9@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: kgunda@codeaurora.org Cc: Abhijeet Dharmapurikar , David Collins , Christophe JAILLET , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, linux-arm-msm-owner@vger.kernel.org On 06/06, kgunda@codeaurora.org wrote: > On 2017-06-02 12:56, kgunda@codeaurora.org wrote: > >On 2017-05-31 23:23, Stephen Boyd wrote: > >>On 05/30, Kiran Gunda wrote: > >>>From: Subbaraman Narayanamurthy > >>> > >>>Currently, cleanup_irq() is invoked when a peripheral's interrupt > >>>fires and there is no mapping present in the interrupt domain of > >>>spmi interrupt controller. > >>> > >>>The cleanup_irq clears the arbiter bit, clears the pmic interrupt > >>>and disables it at the pmic in that order. The last disable in > >>>cleanup_irq races with request_irq() in that it stomps over the > >>>enable issued by request_irq. Fix this by not writing to the pmic > >>>in cleanup_irq. The latched bit will be left set in the pmic, > >>>which will not send us more interrupts even if the enable bit > >>>stays enabled. > >>> > >>>When a client wants to request an interrupt, use the activate > >>>callback on the irq_domain to clear latched bit. This ensures > >>>that the latched, if set due to the above changes in cleanup_irq > >>>or when the bootloader leaves it set, gets cleaned up, paving way > >>>for upcoming interrupts to trigger. > >>> > >>>With this, there is a possibility of unwanted triggering of > >>>interrupt right after the latched bit is cleared - the interrupt > >>>may be left enabled too. To avoid that, clear the enable first > >>>followed by clearing the latched bit in the activate callback. > >>> > >>>Signed-off-by: Subbaraman Narayanamurthy > >>>Signed-off-by: Kiran Gunda > >> > >>Please squash this with the patch that adds cleanup_irq() and > >>rewrite the commit text to combine details from both. > >Sure. Will squash it in the next patch submission. > Patch that adds cleanup_irq is already taken in to the tree. > Lets have this patch as is now. Is this the one with the kbuild error? IRQ domains are not always there, so I don't know how this is expected to work. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project