From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbdFMGEW (ORCPT ); Tue, 13 Jun 2017 02:04:22 -0400 Received: from ozlabs.org ([103.22.144.67]:57535 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbdFMGEU (ORCPT ); Tue, 13 Jun 2017 02:04:20 -0400 Date: Tue, 13 Jun 2017 16:04:18 +1000 From: Stephen Rothwell To: Greg KH Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Sergey Senozhatsky Subject: linux-next: build failure after merge of the driver-core tree Message-ID: <20170613160418.655a8f12@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, After merging the driver-core tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/block/zram/zram_drv.c:1296:28: error: expected ')' before numeric constant static CLASS_ATTR(hot_add, 0400, hot_add_show, NULL); ^ drivers/block/zram/zram_drv.c:1330:3: error: 'class_attr_hot_add' undeclared here (not in a function) &class_attr_hot_add.attr, ^ drivers/block/zram/zram_drv.c:1282:16: warning: 'hot_add_show' defined but not used [-Wunused-function] static ssize_t hot_add_show(struct class *class, ^ Caused by commit 27104a53d02e ("zram: use class_groups instead of class_attrs") I have reverted that commit for today (and commit ecbaa83ee84c ("driver core: remove class_attrs from struct class") temporarily so the the tree will build). -- Cheers, Stephen Rothwell